-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply correct markup to selected breadcrumb items #833
Conversation
🦋 Changeset detectedLatest commit: 338172c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A couple of tiny things but happy to approve as neither are required changes
Summary
Fixes #819
Changes the markup applied to selected breadcrumb items to be a non-interactive element. This removes tab focus from these items, making them inaccessible via keyboard navigation.
🔗 Preview
List of notable changes:
Steps to test:
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots:
Before:
Screen.Recording.2024-11-14.at.9.41.02.AM.mov
After:
Screen.Recording.2024-11-26.at.14.10.41.mov