-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh labels #1034
Refresh labels #1034
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/j11mu7ck5 |
With some colors we're kinda "cheating".. or "work around the system". For example instead of using... .Label--green {
color: $text-green;
border-color: $border-green;
} ...we use: .Label--green {
color: $green-600;
border-color: $green-500;
} So I wonder if it would be better to change these "default" - $text-green: $green-500;
+ $text-green: $green-600;
- $border-green: $green-400;
+ $border-green: $green-500; Anyways, we can come back to balance the colors in a follow-up PR. |
There is a new Not sure if it's a good idea to add it? It's like |
Is there any way to know easily where we use this border other than labels? I changed it to the darker one because the current one is too light so with any green text that passes contrast it looks too different.
I think we might find ourselves not passing contrast ratio. Do you have an idea of a use case that could benefit from these? |
We can search where they get used, but yeah.. it's not easy to find the right URL to also see the example. For now, maybe better to just change the labels. We can revisit this later.
On dotcom there is a script that switches between light/dark text color for the issue labels. So it would need to be something similar. But yeah, let's remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! 🙌
This updates the labels.
👀 Preview
It's probably not the final version, but maybe ok to start testing on dotcom.
TODO
API changes
There should be no breaking changes. But there are a few additions:
.Counter--small
.Label--yellow
.Label--red
.Label--green
.Label--blue
/cc @primer/ds-core