Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component refresh tweaks II #1047

Merged
merged 9 commits into from
Mar 26, 2020
Merged

Component refresh tweaks II #1047

merged 9 commits into from
Mar 26, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 13, 2020

1. Labels

Adds .Label--purple and .Label--pink

image

2. UnderlineNav

The icon is a bit darker for selected items, see https://github.com/github/design-systems/issues/770#issuecomment-597369833.

Screen Shot 2020-03-13 at 4 10 37 PM

3. Avatars

Uses 4px rounded corners for .avatar-small and avatar stacks.

Screen Shot 2020-03-20 at 11 56 43 AM

This also adds some variables and a utility class:

  • $border-radius-1: 4px;
  • $border-radius-2: 6px; -> same as the default $border-radius.
  • .rounded -> uses the default $border-radius variable

4. Social count

Makes sure the height matches the button when zooming. https://github.com/github/design-systems/issues/769#issuecomment-598424402

5. Pagination

Now also uses #f9826c for the border. -> https://github.com/github/design-systems/issues/770#issuecomment-603131123

6. Menu

Removed background color on selected .menu item. -> https://github.com/github/design-systems/issues/770#issuecomment-603131123

7. Button + lables

Now use $blue-500. -> https://github.com/github/design-systems/issues/770#issuecomment-603688126

@vercel
Copy link

vercel bot commented Mar 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/dmx3ybquv
✅ Preview: https://primer-css-git-next-2.primer.now.sh

@vercel vercel bot temporarily deployed to Preview March 19, 2020 08:05 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2020 08:30 Inactive
@vercel vercel bot temporarily deployed to Preview March 20, 2020 02:29 Inactive
@simurai simurai requested a review from auareyou March 24, 2020 04:14
@simurai simurai marked this pull request as ready for review March 24, 2020 04:14
@simurai simurai changed the title More "component refresh" tweaks Component refresh tweaks II Mar 24, 2020
Copy link
Contributor

@auareyou auareyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is $border-radius-3for?

@vercel vercel bot temporarily deployed to Preview March 25, 2020 14:09 Inactive
@simurai
Copy link
Contributor Author

simurai commented Mar 26, 2020

What is $border-radius-3for?

For cases that used to be rounder than the default. But those cases might not have to change and can keep using the new default of 6px. I removed the $border-radius-3 again until we really need it.

@vercel vercel bot temporarily deployed to Preview March 26, 2020 05:36 Inactive
@simurai simurai requested a review from auareyou March 26, 2020 05:38
Copy link
Contributor

@auareyou auareyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Simon!! 🙌

@simurai simurai merged commit 587c61f into next Mar 26, 2020
@simurai simurai deleted the next-2 branch March 26, 2020 10:56
@simurai simurai mentioned this pull request Jul 2, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants