-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component refresh tweaks II #1047
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/dmx3ybquv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is $border-radius-3
for?
For cases that used to be rounder than the default. But those cases might not have to change and can keep using the new default of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go Simon!! 🙌
1. Labels
Adds
.Label--purple
and.Label--pink
2. UnderlineNav
The icon is a bit darker for selected items, see https://github.com/github/design-systems/issues/770#issuecomment-597369833.
3. Avatars
Uses
4px
rounded corners for.avatar-small
and avatar stacks.This also adds some variables and a utility class:
$border-radius-1: 4px;
$border-radius-2: 6px;
-> same as the default$border-radius
..rounded
-> uses the default$border-radius
variable4. Social count
Makes sure the height matches the button when zooming. https://github.com/github/design-systems/issues/769#issuecomment-598424402
5. Pagination
Now also uses
#f9826c
for the border. -> https://github.com/github/design-systems/issues/770#issuecomment-6031311236. Menu
Removed background color on selected
.menu
item. -> https://github.com/github/design-systems/issues/770#issuecomment-6031311237. Button + lables
Now use
$blue-500
. -> https://github.com/github/design-systems/issues/770#issuecomment-603688126