Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-sass #1161

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Upgrade node-sass #1161

merged 3 commits into from
Nov 11, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Sep 8, 2020

This PR does the following suggested in #796 (comment).

FYI, according to sass/node-sass#2625 (comment), running npm audit --fix and committing package-lock.json should resolve this now.

$ npm audit --fix

found 1898 vulnerabilities (1853 low, 1 moderate, 44 high) in 2904 scanned packages
  run `npm audit fix` to fix 1768 of them.
  2 vulnerabilities require semver-major dependency updates.
  128 vulnerabilities require manual review. See the full report for details.

No changes to commit, so I ran:

$ npm audit fix

fixed 1768 of 1898 vulnerabilities in 2904 scanned packages
  128 vulnerabilities required manual review and could not be updated
  2 package updates for 2 vulnerabilities involved breaking changes
  (use `npm audit fix --force` to install breaking changes; or refer to `npm audit` for steps to fix these manually)

Is this ok to merge?

@vercel
Copy link

vercel bot commented Sep 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/cfvcp7tsl
✅ Preview: https://primer-css-git-npm-audit-fix.primer.vercel.app

@simurai simurai requested a review from BinaryMuse September 8, 2020 04:09
@simurai simurai marked this pull request as draft September 9, 2020 02:42
@vercel vercel bot temporarily deployed to Preview November 10, 2020 20:56 Inactive
@BinaryMuse
Copy link
Contributor

Merged in latest changes from the main branch; if things still build and the site is fine I think it's 👍

@simurai
Copy link
Contributor Author

simurai commented Nov 11, 2020

if things still build and the site is fine I think it's 👍

Browsed a bit around on https://primer-css-git-npm-audit-fix.primer.vercel.app/css/ and things still look good.

@simurai simurai marked this pull request as ready for review November 11, 2020 04:57
@vercel vercel bot temporarily deployed to Preview November 11, 2020 04:57 Inactive
@simurai simurai merged commit e8e2ccd into master Nov 11, 2020
@simurai simurai deleted the npm-audit-fix branch November 11, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants