Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background from .note #1517

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Remove background from .note #1517

merged 2 commits into from
Jul 29, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 29, 2021

This partially reverts #1507 and moves the opaque background from .note to the "state" classes. This should fix the notifications:

image (2)

As well as the form tooltips:

Screen Shot 2021-07-20 at 15 23 55

Initially I thought that the .note class is only used for these form tooltips, but turns out it a more commonly used class.. I guess to make text smaller?

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2021

🦋 Changeset detected

Latest commit: 5612db2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simurai
Copy link
Contributor Author

simurai commented Jul 29, 2021

Gonna merge this already, since it's a bit more urgent. 🏇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant