Improve font rendering on Linux #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt at fixing #1209. Further reading: - https://infinnie.github.io/blog/2017/systemui.html - https://blog.jim-nielsen.com/2020/system-fonts-on-the-web/
🦋 Changeset detectedLatest commit: efc7d4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vdepizzol
changed the title
simurai
approved these changes
Aug 12, 2021
|
|
||
| // Windows | ||
| // Note this should be prioritized over `system-ui` to avoid legacy fonts. | ||
| // See https://infinnie.github.io/blog/2017/systemui.html |
There was a problem hiding this comment.
This post seems to be from 2017? So the browser/OS bugs might be fixed by now? On the other hand, I'm not sure how to test the problems. So maybe still good to keep "Segoe UI". 🤷
This was referenced Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to #1209. It adds
system-uito the $body-font stack while still prioritizing "Segoe UI" on Windows to avoid possible incorrect renderings described in this article.As explored by @nikwen,
system-uishould allow Linux distros to render their UI fonts (Cantarell, Oxygen, Ubuntu, Inter etc).I've also added Windows 11's Segoe UI Variable to the stack.
Further reading:
/cc @primer/ds-core