-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update utilities #1630
Update utilities #1630
Conversation
🦋 Changeset detectedLatest commit: a8a9cba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks @simurai - The only thing I'd change is I would remove 'subtle' and 'muted' from the naming in color role backgrounds and borders. For example:
This one folks don't need to guess what muted or subtle is, they'll just know it's not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Yeah, I was debating about that too. It would make it less verbose and without the bg -> subtle, border -> muted oddity. My thinking was that when seeing Another point is that when searching for There might be a regex for only finding Anyone else with strong opinions about it? Maybe @ashygee? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be a regex for only finding
color-bg-accent
and excludingcolor-bg-accent-emphasis
?
You can regex search like this color-bg-accent[^-]
where the last character would be anything except -
.
Nice. Saved for later. 👍 |
This updates the utilities.
muted
roles are now used for borders, instead of backgroundsneutral
backgrounds are removed.color-bg-neutral-emphasis-plus
got renamed to.color-bg-emphasis
and is the replacement for.color-bg-canvas-inverse
in v1