Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageLayout component / Layout beta + storybook #1737

Merged
merged 56 commits into from
Dec 21, 2021
Merged

PageLayout component / Layout beta + storybook #1737

merged 56 commits into from
Dec 21, 2021

Commits on Nov 2, 2021

  1. storybook for layout alpha

    @vdepizzol
    vdepizzol committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    9fd9354 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Merge branch 'main' of https://github.com/primer/css into layout-stories

    @vdepizzol
    vdepizzol committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e7f1742 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. the beginning of layout beta

    @vdepizzol
    vdepizzol committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    cbd3da7 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. simplify spacing structure and other things 

    this is a reminder that all the abstraction can happen in the viewComponent;
there's no need to flood the css with constricted behaviors
    @vdepizzol
    vdepizzol committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    66bebe1 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. add rowGap & dividers, clean spacing props

    @vdepizzol
    vdepizzol committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    f3e6953 View commit details
    Browse the repository at this point in the history

  2. content-width support, sticky pane

    @vdepizzol
    vdepizzol committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    bd151ed View commit details
    Browse the repository at this point in the history

  3. cleanup props

    @vdepizzol
    vdepizzol committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    4270c7b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. add preset property

    @vdepizzol
    vdepizzol committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    debfde9 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2021

  1. !default

    @vdepizzol
    vdepizzol committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    e24b05b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. component name & settings example

    @vdepizzol
    vdepizzol committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    896dd94 View commit details
    Browse the repository at this point in the history

  2. typo, cleaner header & footer template

    @vdepizzol
    vdepizzol committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    93faca8 View commit details
    Browse the repository at this point in the history

  3. fix preset options

    @vdepizzol
    vdepizzol committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    a73f383 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. mobile-friendly responsive behavior

    @vdepizzol
    vdepizzol committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    368bcf6 View commit details
    Browse the repository at this point in the history

  2. ongoing flowVertical breakpoint behavior

    @vdepizzol
    vdepizzol committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    22ddcdf View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. finish panePosition + responsive pos & dividers

    @vdepizzol
    vdepizzol committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    06ab457 View commit details
    Browse the repository at this point in the history

  2. panePosition fix

    @vdepizzol
    vdepizzol committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    28a9e40 View commit details
    Browse the repository at this point in the history

  3. add splitAsPage, finish responsive divider

    @vdepizzol
    vdepizzol committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    398c874 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Layout beta ongoing updates (#1779) 

    - simplify component with better names
- rename it to `PageLayout`
- stylelint cleanup
- finalize responsive variants
- finalize variant-specific region dividers
    @vdepizzol
    vdepizzol authored Dec 8, 2021
    Configuration menu
    Copy the full SHA
    5faad0a View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. add minimum 320px viewport

    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    df66858 View commit details
    Browse the repository at this point in the history

  2. fix layout alpha, add layout patterns

    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    2605797 View commit details
    Browse the repository at this point in the history

  3. cleanup bg colors, stylint pass

    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    1115ebc View commit details
    Browse the repository at this point in the history

  4. enable debug bg colors

    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    ede115c View commit details
    Browse the repository at this point in the history

  5. colorful regions by default for dubugging

    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    b655c33 View commit details
    Browse the repository at this point in the history

  6. "Needless disable for primer/no-undefined-vars"

    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    d116b21 View commit details
    Browse the repository at this point in the history

  7. Stylelint auto-fixes

    @actions-user
    actions-user committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    c75e91b View commit details
    Browse the repository at this point in the history

  8. line breaks a EOF

    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    dc9a79d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'layout-stories' of https://github.com/primer/css into l… 

    …ayout-stories
    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    e9ec951 View commit details
    Browse the repository at this point in the history

  10. introduce page layout behavior as a sb helper

    @vdepizzol
    vdepizzol committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    a326a8d View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. children props in specialized components

    @vdepizzol
    vdepizzol committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    fef80f4 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @vdepizzol
    vdepizzol committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    56afe07 View commit details
    Browse the repository at this point in the history

  3. typo

    @vdepizzol
    vdepizzol committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    bbfcee3 View commit details
    Browse the repository at this point in the history

  4. discussions responsive temporary example

    @vdepizzol
    vdepizzol committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    fda8c21 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2021

  1. layout alpha descriptions

    @vdepizzol
    vdepizzol committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    59bb220 View commit details
    Browse the repository at this point in the history

  2. pageLayout prop descriptions

    @vdepizzol
    vdepizzol committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    dc06b5e View commit details
    Browse the repository at this point in the history

  3. cleanup

    @vdepizzol
    vdepizzol committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    3657b2a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into layout-stories

    @vdepizzol
    vdepizzol authored Dec 11, 2021
    Configuration menu
    Copy the full SHA
    9d0eb1b View commit details
    Browse the repository at this point in the history

  5. fix conflict

    @vdepizzol
    vdepizzol committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    1737cfd View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. copy

    @vdepizzol
    vdepizzol committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    1c2dcad View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. responsiveVariant storybook description

    @vdepizzol
    vdepizzol authored Dec 15, 2021
    Configuration menu
    Copy the full SHA
    aa6eba5 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Merge branch 'main' of https://github.com/primer/css into layout-stories

    @vdepizzol
    vdepizzol committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    a1f4107 View commit details
    Browse the repository at this point in the history

  2. 0 padding on fullscreen storybook layout

    @vdepizzol
    vdepizzol committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    e0abc21 View commit details
    Browse the repository at this point in the history

  3. has__divider for boolean props

    @vdepizzol
    vdepizzol committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    b4332b2 View commit details
    Browse the repository at this point in the history

  4. cleanup, copy

    @vdepizzol
    vdepizzol committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    7491602 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @vdepizzol
    vdepizzol committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    fb8c477 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @vdepizzol
    vdepizzol committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    afa6061 View commit details
    Browse the repository at this point in the history

  7. cleanup chained selections/descendants

    @vdepizzol
    vdepizzol committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    0ce4caa View commit details
    Browse the repository at this point in the history

  8. Stylelint auto-fixes

    @actions-user
    actions-user committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    3a98c9c View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. inherit values for responsive divider props

    @vdepizzol
    vdepizzol committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    a652d73 View commit details
    Browse the repository at this point in the history

  2. consolidate modifier names for responsive props 

    Changelog:

### CSS classes
- `PageLayout--variant-stackRegions` → `PageLayout--responsive-stackRegions`
- `PageLayout--variant-separateRegions` → `PageLayout--responsive-separateRegions`
- `PageLayout--variant-stackRegions-panePos-*` →`PageLayout--responsive-panePos-*`
- `PageLayout--variant-separateRegions-primary-*` →`PageLayout--responsive-primary-*`
- `PageLayout-region--hasDivider-*` → `PageLayout-region--dividerNarrow-*`

### Prop names
- `responsivePrimaryRegion` → `primaryRegion`
- `paneResponsivePosition` → `panePositionNarrow`
- `paneResponsiveDivider` → `paneDividerNarrow`
- `headerResponsiveDivider`→ `headerDividerNarrow`
- `footerResponsiveDivider`→ `footerDividerNarrow`

### Args
- `*DividerNarrow` props have new `inherit` value by default
    @vdepizzol
    vdepizzol committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    4e707a6 View commit details
    Browse the repository at this point in the history

  3. Create lemon-games-swim.md

    @langermank
    langermank authored Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e8eb697 View commit details
    Browse the repository at this point in the history

  4. Update lemon-games-swim.md

    @langermank
    langermank authored Dec 21, 2021
    Configuration menu
    Copy the full SHA
    f039894 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into layout-stories

    @vdepizzol
    vdepizzol authored Dec 21, 2021
    Configuration menu
    Copy the full SHA
    8bd4a3d View commit details
    Browse the repository at this point in the history

  6. cleanup, header+footer dividers as local modifiers

    @vdepizzol
    vdepizzol committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e351cea View commit details
    Browse the repository at this point in the history

  7. Merge branch 'layout-stories' of https://github.com/primer/css into l… 

    …ayout-stories
    @vdepizzol
    vdepizzol committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    3fd332c View commit details
    Browse the repository at this point in the history

  8. hasFooterDivider instead of footerDivider

    @vdepizzol
    vdepizzol committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    8641c30 View commit details
    Browse the repository at this point in the history

  9. fix primaryRegion selector

    @vdepizzol
    vdepizzol committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0f5f357 View commit details
    Browse the repository at this point in the history