Support fractional viewport sizes for max-width
media queries
#1827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This came up in #1737 (comment) and adds support for "fractional viewport sizes" where we use
max-width
media queries. Like for thehide
utilities.What approach did you choose and why?
Using
- 0.02px
instead of- 1px
should add better support for hi-dpi screens or zooming. From https://www.w3.org/TR/mediaqueries-4/#mq-min-maxIn case you're wondering why
- 0.02px
and not- 0.01px
:What should reviewers focus on?
Should this rather be a variable? How should we call it?
Are additional changes needed?