-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionList item outlines for high contrast theme #1856
Conversation
🦋 Changeset detectedLatest commit: a02806b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Vinicius Depizzol <vdepizzol@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@langermank The addition of a background color will overlay the vertical connections for tree-view. Is this okay, or do we need to address with a fix?
Hmm.. maybe ok since the background just appears on hover/active? If the "vertical connections" would be on top of the background, that might would feel awkward?
Another option could be to indent the background/border so that they don't cover the "vertical connections".
@langermank and I talked about this option in other scenarios such as Regarding the vertical indentation lines/styles, I think we can improve those a little bit design-wise. When viewing multiple folders with single files inside, it becomes quite obvious they're too noisy. 🤔 |
src/actionlist/action-list-item.scss
Outdated
50% { | ||
box-shadow: inset 0 0 0 rgba(#000, 0.04); | ||
// this could work if primitive supported rgb (not valid right now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to compromise on the fun interaction here for now. We could stack box-shadows to ensure we have a contrast border around the shadow that makes the item feel like its shrinking, but its not valid to use rgba()
on a CSS variable that resolves as a hex. It would need to be rgb
. 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@langermank sorry I missed this comment!
I think we could remove the inset box-shadow
while keeping the scaling interaction in that case :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vdepizzol no worries! Okie, I think I got it 👍
What are you trying to accomplish?
This adds a few more improvements to the
ActionList
, mainly::hover
and:active
state for the "Light high contrast" theme.What approach did you choose and why?
outline
for:hover/:active
that istransparent
in most themes, except for the "high contrast" themes.What should reviewers focus on?
border
for the:hover/:active
state to not have to change any sizes. Downside is that in Safari the rounded corners are missing.Are additional changes needed?
primer/primitives
needs to be bumped to7.4.0
to include the new variables used in this PR.