Remove yarn in favor of npm #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20fc448 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
commented
May 12, 2023
| @@ -37,7 +37,7 @@ jobs: | |||
| run: | | |||
| version=$(jq -r .version package.json) | |||
| echo "$( jq ".version = \"$(echo $version)-rc.$(git rev-parse --short HEAD)\"" package.json )" > package.json | |||
| yarn publish --tag next | |||
| npm publish --tag next | |||
There was a problem hiding this comment.
Is this the correct publish command?
langermank
approved these changes
May 12, 2023
|
I can't seem to get gatsby to play along here, @lukasoppermann since you did the primitives change, do you have ideas? |
simurai
approved these changes
May 15, 2023
|
I can't get this to work with the docs folder :( |
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This aligns the packaging tools we use here with the other libraries
primer/react, primer/view_components. We dropped yarn in those libraries in favor of npm.What approach did you choose and why?
When we chose yarn a while back it had features that appealed to us that npm didn't have, but since then they've become feature complete. Npm is the easier choice then because it's more standard.
What should reviewers focus on?
Did I miss any
yarnstatements?Can these changes ship as is?