Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button color contrast improvements #418

Merged
merged 7 commits into from
Jan 16, 2018
Merged

Button color contrast improvements #418

merged 7 commits into from
Jan 16, 2018

Conversation

broccolini
Copy link
Member

@broccolini broccolini commented Jan 3, 2018

Some quick fixes to address color accessibility issues reported in https://github.com/github/github/issues/82929

  • Reduced opacity for italics in buttons which are used for things like "branch" or "base" in the code tab or pull requests. I'm not a fan of using the <i> tag in this way but unsure of how much work it would be to update in github/github so may need to follow up on this. Aside from targetting a type selector in an unusual way, we also can't guarantee that the resulting color will pass contrast in other color combinations.
  • Reduced alpha transparency for button focus for colored buttons from 0.3 to 0.4 - this isn't really a fix, just a slight improvement. Default focus outlines don't pass color contrast so it's not something I've considered before, however the default is noticeably darker and people still need to see it (for example if you used a keyboard rather than a mouse due to motor control issues). Having the same alpha transparency for every color isn't necessarily the best approach either because some hues have more range than other which will affect their perceived lightness. Coupled by the fact that our green is too light at the moment, the focus is still very light. I'll follow up with another pass that will either address the green color or de-couple the mixin for focus from the hue.

/cc @primer/ds-core

@broccolini broccolini changed the title Btn contrast Button color contrast improvements Jan 3, 2018
@broccolini broccolini mentioned this pull request Jan 3, 2018
17 tasks
@broccolini broccolini changed the base branch from dev to release-10.3.0 January 10, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants