Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(progress): beef up progress docs, fix #750 #751

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Apr 9, 2019

This fixes #750 by removing references to a non-existent Progress-value class, and beefs up the Progress component docs with more explicit guidance and a section on accessibility. When deployed it should be visible here:

https://primer-css-progress-docs.now.sh/css/components/progress

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@simurai simurai changed the base branch from master to release-12.2.3 April 15, 2019 23:59
@simurai simurai merged commit c47084f into release-12.2.3 Apr 16, 2019
@simurai simurai deleted the progress-docs branch April 16, 2019 00:00
@simurai simurai mentioned this pull request Apr 16, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants