Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more responsive border utilities #775

Merged
merged 13 commits into from
May 14, 2019
Merged

Add more responsive border utilities #775

merged 13 commits into from
May 14, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Apr 30, 2019 •
edited
Loading

This adds the following responsive border utilities:

  • .border-{breakpoint}-0 removes borders on all sides responsively, a la .border-0.
  • .border-{breakpoint} adds borders on all sides responsively, a la .border. I had this as .border-{breakpoint}-1, but removed the -1 suffix at @simurai's recommendation.
  • For consistency, I've also added .border-x for horizontal borders only.
  • The docs explain how all of the permutations work.

Closes #756

@shawnbot shawnbot requested a review from simurai April 30, 2019 16:34
@shawnbot shawnbot mentioned this pull request Apr 30, 2019
Merged
13 tasks
shawnbot
shawnbot commented Apr 30, 2019
View reviewed changes
src/utilities/borders.scss Outdated Show resolved Hide resolved
simurai
simurai requested changes May 1, 2019
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion to change the example. And not sure about the -1. Otherwise 👍 .

src/utilities/borders.scss Show resolved Hide resolved
pages/css/utilities/borders.md Outdated Show resolved Hide resolved
pages/css/utilities/borders.md Outdated Show resolved Hide resolved
src/utilities/borders.scss Outdated Show resolved Hide resolved
@simurai @shawnbot
use md breakpoints in responsive border examples
1b1033e 
Co-Authored-By: shawnbot <shawn.allen@github.com>
@shawnbot shawnbot changed the base branch from release-12.3.0 to master May 9, 2019 20:46
@shawnbot shawnbot requested a review from simurai May 9, 2019 21:25
simurai
simurai approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to 🚢 👍 .

@shawnbot shawnbot changed the base branch from master to release-12.4.0 May 14, 2019 20:25
@shawnbot shawnbot mentioned this pull request May 14, 2019
Merged
11 tasks
@shawnbot shawnbot merged commit 0a14c1c into release-12.4.0 May 14, 2019
@shawnbot shawnbot deleted the more-border-utils branch May 14, 2019 20:35
This was referenced Dec 18, 2022
Open
Open
This was referenced Dec 25, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
minor release Tag: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @simurai