-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish deprecation data #883
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-deprecations-data.primer.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few little comments and suggestions, but overall this looks good!
Are you planning to add tests to validate the deprecations.json
output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 💯 Left a few comments. The only thing I feel strongly about is adding title
front matter to the documentation page.
Co-Authored-By: Zeke Sikelianos <zeke@sikelianos.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This is the first stab at publishing deprecation data, as described in #740. Here's what accessing it looks like:
JSON
outputs:
See the Markdown docs (and the published page) for usage instructions.
Closes #740