Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inlay hint colors #278

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Conversation

clavin
Copy link
Contributor

@clavin clavin commented May 9, 2022

This PR adds styles to color inlay hints. I based the style off how inline code looks on GitHub, using the appropriate primer colors.

Examples

Both examples are of Rust code using the Light Default & Dark Default themes. The example code is taken from Rust By Example.

Light Default:
screenshot of the light theme

Dark Default:
screenshot of the dark theme

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2022

🦋 Changeset detected

Latest commit: a877e3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
github-vscode-theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I can't reproduce this, but I probably need to enable something or have the right code example to see the inlay hints. 🤔

Anyways, screenshots look good. 👍

@simurai simurai merged commit ca5d287 into primer:main Jul 13, 2022
@primer-css primer-css mentioned this pull request Jul 13, 2022
@clavin
Copy link
Contributor Author

clavin commented Jul 13, 2022

Those hints are commonly added by extensions, in my example it was Rust Analyzer adding them. Thank you for adding this in! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants