[FIX] Update diff highlighting

[Mekomancer]

Closes #325

[changeset-bot]

🦋 Changeset detected

Latest commit: ed605f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
github-vscode-theme	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[lukasoppermann]

Hey @Mekomancer I think this sadly does not work because there are a lot of possible layering problems where this color is layered on top of other things that need to be visible through the color.

I think @simurai can let us know if my assumption is correct or not.

[simurai]

where this color is layered on top of other things

👍 Yes, most of the backgrounds need to be semi-transparent so that underlaying layers remain visible. Things like selections or bracket/word matcher. From the VS Code docs:

The color must not be opaque so as not to hide underlying decorations.

It's a shame we can't use the colors from Primitives, but the VS Code theme is a bit an edge case in that regard.

[simurai]

Took another look. The current diff should already have more contrast than the screenshots in #325, but with 1be76bb I increased the contrast for diff colors a bit more, but still kept it semi-transparent. Here the changes:

github.com	Before	After