Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate font-based Octicons #108

Closed
aaronshekey opened this issue Jul 3, 2016 · 2 comments · Fixed by #117
Closed

Deprecate font-based Octicons #108

aaronshekey opened this issue Jul 3, 2016 · 2 comments · Fixed by #117

Comments

@aaronshekey
Copy link
Contributor

It's a lot of work to support the font-based Octicons. Doing so in 4.0 has introduced some regressions #107. We also rely very heavily on grunt-webfont, which isn't the most active project out there. We won't be able to realistically dog food the font version since github.com has since switched to SVG.

I think we should consider deprecating font-based Octicons.

Thoughts @jonrohan?
@jonrohan
Copy link
Member

jonrohan commented Jul 5, 2016

I can't think of any of our own properties that still use the webfont. I'd be down for deprecating it. Maybe 5.0?

@jonrohan jonrohan mentioned this issue Sep 9, 2016
Merged
@dmitshur dmitshur mentioned this issue Sep 17, 2016
Closed
@jonrohan jonrohan mentioned this issue Sep 29, 2016
Closed
@brillout
Copy link

A note about that in the readme and release notes would be convenient.

dmitshur added a commit to shurcooL-legacy/octicons that referenced this issue Jan 21, 2017
@dmitshur
Deprecate package in favor of octiconssvg.
101c55d 
GitHub has deprecated the icon font version of Octicons in favor of
SVG. See primer/octicons#108, and
https://github.com/blog/2112-delivering-octicons-with-svg for
motivation.

Package github.com/shurcooL/octiconssvg should be used instead, which
provides Octicons in SVG format.
dmitshur added a commit to shurcooL-legacy/octicons that referenced this issue Jan 21, 2017
@dmitshur
Deprecate package in favor of octiconssvg.
d190b00 
GitHub has deprecated the icon font version of Octicons in favor of SVG.
See primer/octicons#108, and
https://github.com/blog/2112-delivering-octicons-with-svg for
motivation.

Package github.com/shurcooL/octiconssvg should be used instead, which
provides Octicons in SVG format.
@shgysk8zer0 shgysk8zer0 mentioned this issue Feb 24, 2017
Closed
@dmitshur dmitshur mentioned this issue Jul 21, 2017
Closed
@kevinjm39 kevinjm39 mentioned this issue Feb 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing the webfont and everything that builds the webfont primer/octicons
3 participants
@jonrohan @brillout @aaronshekey