Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(octicons_react): include extension in type declaration #1020

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

joshblack
Copy link
Member

Closes #1018

Add an explicit extension for the types to support different moduleResolution options. This also adds in a step to the CI to run arethetypeswrong to make sure that we don't regress here in the future 👀

@joshblack joshblack requested a review from a team as a code owner April 15, 2024 17:36
@joshblack joshblack requested a review from siddharthkp April 15, 2024 17:36
Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: ac146f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh nice!

Just double checking, is this safe to publish as a patch release?

@joshblack
Copy link
Member Author

joshblack commented Apr 17, 2024

@siddharthkp I believe so since this will be fixing the issue to what the intent was. Let me know if there is something in particular that we should be guarding against / looking for 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Esm requires file extension in d.ts files.
2 participants