Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thumbsup and thumbsdown icons #1033

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Update thumbsup and thumbsdown icons #1033

merged 11 commits into from
Oct 7, 2024

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Oct 3, 2024

The current thumbsup and thumbsdown octicons have always felt a little too cartoony to me and don't match the style of the rest of the icons. I took a stab at redesigning them:

image

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: e2a199c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis marked this pull request as ready for review October 3, 2024 20:22
@colebemis colebemis requested review from a team as code owners October 3, 2024 20:22
@samoshin
Copy link

samoshin commented Oct 3, 2024

I'm inclined to 👍 it 😏 . @tallys?

@tallys
Copy link
Contributor

tallys commented Oct 4, 2024

LGTM 👍 👍

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tallys
Copy link
Contributor

tallys commented Oct 4, 2024

cc @lukasoppermann

@lukasoppermann
Copy link
Contributor

LGTM image

@tallys tallys enabled auto-merge (squash) October 7, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants