Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar expand and collapse icons #569

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Conversation

colebemis
Copy link
Contributor

image

@vercel
Copy link

vercel bot commented Mar 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/EYFVPCNWDtJTEn1n7GTCT6mzp3Fb
✅ Preview: https://octicons-git-sidebar-icons-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview March 31, 2021 03:43 Inactive
@ashygee
Copy link
Contributor

ashygee commented Mar 31, 2021

@colebemis is collapse and expand the correct descriptor for this? not open/close?

@colebemis
Copy link
Contributor Author

@ashygee I'm fine with either.

@colebemis
Copy link
Contributor Author

expand/collapse feel like they represent the action of "expanding" or "collapsing" which is how the icons will be used. open/close feel more like they could be states of the sidebar.

@ashygee ashygee requested a review from pmarsceill March 31, 2021 17:32
@ashygee ashygee mentioned this pull request Apr 1, 2021
14 tasks
@ashygee
Copy link
Contributor

ashygee commented Apr 1, 2021

expand/collapse feel like they represent the action of "expanding" or "collapsing" which is how the icons will be used. open/close feel more like they could be states of the sidebar.

This makes perfect sense. let's keep as is then! 🚀 it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants