Skip to content

Commit

Permalink
rm build for v1
Browse files Browse the repository at this point in the history
  • Loading branch information
lukasoppermann committed Apr 18, 2024
1 parent e032ac6 commit 16faf34
Show file tree
Hide file tree
Showing 45 changed files with 11 additions and 3,315 deletions.
5 changes: 5 additions & 0 deletions .changeset/four-bulldogs-search.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/primitives': major
---

remove v1 tokens and build process
4 changes: 0 additions & 4 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
tokens-v2-private/
CHANGELOG.md


# Ignore all files relating to v1 tokens
# TODO: Remove after v1 tokens have been removed
data/
dist/
src/@types/
scripts/lib/
scripts/build.ts
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ jobs:
- name: Install dependencies
run: npm ci --no-audit --no-fund --ignore-scripts

- name: Build v1 tokens
run: npm run build

- name: Build v8 tokens
run: npm run build:next

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ jobs:
with:
node_version: 20
install: npm ci --legacy-peer-deps --no-audit --no-fund && npm run install:storybook
build: npm run build:tokens && npm run build && npm run build:next && cd docs/storybook && npm run build:prod
build: npm run build:tokens && npm run build:next && cd docs/storybook && npm run build:prod
output_dir: docs/public

2 changes: 1 addition & 1 deletion .github/workflows/deploy_preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
with:
node_version: 20
install: npm ci --no-audit --no-fund --ignore-scripts && npm run install:storybook
build: npm run build:tokens && npm run build && npm run build:next && cd docs/storybook && npm run build:preview
build: npm run build:tokens && npm run build:next && cd docs/storybook && npm run build:preview
output_dir: docs/public

post_storybook:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/diff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,12 @@ jobs:
- name: Install dependencies
run: npm ci --no-audit --no-fund --include=dev --ignore-scripts

- name: Build tokens
run: npm run build

- name: Build experimental tokens
run: npm run build:tokens

- name: Install dependencies (base)
run: pushd base; npm i --no-audit --no-fund --ignore-scripts; popd

- name: Build (base)
run: pushd base; npm run build; popd

- name: Build (base experimental)
run: pushd base; npm run build:tokens; popd

Expand Down
13 changes: 2 additions & 11 deletions .github/workflows/hasChanged.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,10 @@ on:
outputs:
outputAffected:
description: "Boolean value indicating changes in any file or folder that has an effect on the output"
value: ${{ jobs.hasChanged.outputs.oldTokens || jobs.hasChanged.outputs.src || jobs.hasChanged.outputs.buildScripts }}
value: ${{ jobs.hasChanged.outputs.src || jobs.hasChanged.outputs.buildScripts }}
tokens:
description: "Boolean value indicating change in src/tokens folder"
value: ${{ jobs.hasChanged.outputs.tokens }}
oldTokens:
description: "Boolean value indicating change in data folder"
value: ${{ jobs.hasChanged.outputs.oldTokens }}
src:
description: "Boolean value indicating change in src folder"
value: ${{ jobs.hasChanged.outputs.src }}
Expand All @@ -37,7 +34,6 @@ jobs:
outputs:
outputAffected: ${{ steps.filter.outputs.outputAffected }}
tokens: ${{ steps.filter.outputs.tokens }}
oldTokens: ${{ steps.filter.outputs.oldTokens }}
src: ${{ steps.filter.outputs.src }}
scripts: ${{ steps.filter.outputs.scripts }}
buildScripts: ${{ steps.filter.outputs.buildScripts }}
Expand All @@ -52,32 +48,27 @@ jobs:
filters: |
tokens:
- 'src/tokens/**'
oldTokens:
- 'data/**'
src:
- 'src/**/**.ts'
- 'src/**/**.json'
- 'src/**/**.json5'
scripts:
- 'scripts/**'
buildScripts:
- 'scripts/build.ts'
- 'scripts/buildTokens.ts'
- 'scripts/themes.config.ts'
- 'tsconfig.json'
- 'tsconfig.build.json'
- 'package.json'
dependencies:
- 'package.json'
- 'package-lock.json'
docs:
- 'docs/**'
- name: Detecting changes that effect output
if: steps.filter.outputs.tokens == 'true' || steps.filter.outputs.oldTokens == 'true' || steps.filter.outputs.src == 'true' || steps.filter.outputs.scripts == 'true' || steps.filter.outputs.dependencies == 'true' || steps.filter.outputs.docs == 'true'
if: steps.filter.outputs.tokens == 'true' || steps.filter.outputs.src == 'true' || steps.filter.outputs.scripts == 'true' || steps.filter.outputs.dependencies == 'true' || steps.filter.outputs.docs == 'true'
run: |
echo Changes detected
echo - tokens: ${{ steps.filter.outputs.tokens }}
echo - oldTokens: ${{ steps.filter.outputs.oldTokens }}
echo - src: ${{ steps.filter.outputs.src }}
echo - scripts: ${{ steps.filter.outputs.scripts }}
echo - buildScripts: ${{ steps.filter.outputs.buildScripts }}
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ jobs:
- name: Install dependencies
run: npm ci --no-audit --no-fund && pushd docs; npm ci --no-audit --no-fund; popd

- name: Build tokens
run: npm run build

- name: Build experimental tokens
run: npm run build:tokens

Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/release_canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ jobs:
- name: Install dependencies
run: npm ci --no-audit --no-fund --include=dev

- name: Build tokens
run: npm run build

- name: Build experimental tokens
run: npm run build:tokens

Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/release_candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ jobs:
- name: Install dependencies
run: npm ci --legacy-peer-deps

- name: Build tokens
run: npm run build

- name: Build experimental tokens
run: npm run build:tokens

Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-push
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"
npm run build & npm run test
npm run build:next & npm run test
npm run tokenJson:check
if npm run lint ; then
echo "Lint check passed"
Expand Down
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ storybook-static

# Ignore all files relating to v1 tokens
# TODO: Remove after v1 tokens have been removed
data/
tokens-v2-private/
7 changes: 0 additions & 7 deletions data/colors/deprecated.json

This file was deleted.

21 changes: 0 additions & 21 deletions data/colors/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion data/colors/prefix

This file was deleted.

Loading

0 comments on commit 16faf34

Please sign in to comment.