Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tokens for diff blob #1068

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add tokens for diff blob #1068

merged 1 commit into from
Oct 25, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Sep 30, 2024 •
edited
Loading

Summary

List of notable changes:

Added

  • --diffBlob-hunkNum-fgColor-rest
  • --diffBlob-hunkNum-fgColor-hover
  • --diffBlob-hunkNum-bgColor-rest
  • --diffBlob-hunkNum-bgColor-hover
  • --diffBlob-additionWord-fgColor
  • --diffBlob-deletionWord-fgColor
  • --diffBlob-emptyNum-bgColor
  • --diffBlob-emptyLine-bgColor

Renamed:

  • --diffBlob-addition-fgColor-text -> --diffBlob-additionLine-fgColor
  • --diffBlob-addition-fgColor-num -> --diffBlob-additionNum-fgColor
  • --diffBlob-addition-bgColor-num -> --diffBlob-additionNum-bgColor
  • --diffBlob-addition-bgColor-line -> --diffBlob-additionLine-bgColor
  • --diffBlob-addition-bgColor-word -> --diffBlob-additionWord-bgColor
  • --diffBlob-deletion-fgColor-text -> --diffBlob-deletionLine-fgColor
  • --diffBlob-deletion-fgColor-num -> --diffBlob-deletionNum-fgColor
  • --diffBlob-deletion-bgColor-num -> --diffBlob-deletionNum-bgColor
  • --diffBlob-deletion-bgColor-line -> --diffBlob-deletionLine-bgColor
  • --diffBlob-deletion-bgColor-word -> --diffBlob-deletionWord-bgColor

Removed

  • --diffBlob-hunk-bgColor-num

@lukasoppermann lukasoppermann self-assigned this Sep 30, 2024
@lukasoppermann lukasoppermann requested review from a team as code owners September 30, 2024 09:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2eb2ab4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 30, 2024 09:03 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 30, 2024 13:58 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 2, 2024 16:37 Inactive
@lukasoppermann
Copy link
Contributor Author

@langermank

Technically we would need to move the num part etc. more to the front:

  --diffBlob-hunkText-fgColor
  --diffBlob-hunkNum-fgColor-rest
  --diffBlob-hunkLine-bgColor

Any thoughts about this?

Also I would like to change text to line to be aligned to the other:

  --diffBlob-hunkLine-fgColor
  --diffBlob-hunkLine-bgColor

@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 7, 2024 12:38 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

Design Token Diff

/css/functional/themes/dark-colorblind.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-colorblind.css	2024-10-25 14:17:43.655687481 +0000
@@ -5,17 +5,26 @@
 --topicTag-borderColor: #00000000;
 --highlight-neutral-bgColor: #d2992266;
 --page-header-bgColor: #0d1117;
-  --diffBlob-addition-fgColor-text: #f0f6fc;
-  --diffBlob-addition-fgColor-num: #f0f6fc;
-  --diffBlob-addition-bgColor-num: #58a6ff4d;
-  --diffBlob-addition-bgColor-line: #388bfd26;
-  --diffBlob-addition-bgColor-word: #388bfd66;
-  --diffBlob-deletion-fgColor-text: #f0f6fc;
-  --diffBlob-deletion-fgColor-num: #f0f6fc;
-  --diffBlob-deletion-bgColor-num: #db6d284d;
-  --diffBlob-deletion-bgColor-line: #db6d2826;
-  --diffBlob-deletion-bgColor-word: #db6d2866;
-  --diffBlob-hunk-bgColor-num: #388bfd66;
+  --diffBlob-additionLine-fgColor: #f0f6fc;
+  --diffBlob-additionLine-bgColor: #388bfd26;
+  --diffBlob-additionWord-fgColor: #f0f6fc;
+  --diffBlob-additionWord-bgColor: #388bfd66;
+  --diffBlob-additionNum-fgColor: #f0f6fc;
+  --diffBlob-additionNum-bgColor: #58a6ff4d;
+  --diffBlob-deletionLine-fgColor: #f0f6fc;
+  --diffBlob-deletionLine-bgColor: #db6d2826;
+  --diffBlob-deletionWord-fgColor: #f0f6fc;
+  --diffBlob-deletionWord-bgColor: #db6d2866;
+  --diffBlob-deletionNum-fgColor: #f0f6fc;
+  --diffBlob-deletionNum-bgColor: #db6d284d;
+  --diffBlob-hunkLine-fgColor: #9198a1;
+  --diffBlob-hunkLine-bgColor: #212830;
+  --diffBlob-hunkNum-fgColor-rest: #f0f6fc;
+  --diffBlob-hunkNum-fgColor-hover: #ffffff;
+  --diffBlob-hunkNum-bgColor-rest: #2f3742;
+  --diffBlob-hunkNum-bgColor-hover: #656c76;
+  --diffBlob-emptyNum-bgColor: #151b23;
+  --diffBlob-emptyLine-bgColor: #151b23;
 --diffBlob-expander-iconColor: #9198a1;
 --codeMirror-fgColor: #f0f6fc;
 --codeMirror-bgColor: #0d1117;
@@ -574,17 +583,26 @@
   --topicTag-borderColor: #00000000;
   --highlight-neutral-bgColor: #d2992266;
   --page-header-bgColor: #0d1117;
-    --diffBlob-addition-fgColor-text: #f0f6fc;
-    --diffBlob-addition-fgColor-num: #f0f6fc;
-    --diffBlob-addition-bgColor-num: #58a6ff4d;
-    --diffBlob-addition-bgColor-line: #388bfd26;
-    --diffBlob-addition-bgColor-word: #388bfd66;
-    --diffBlob-deletion-fgColor-text: #f0f6fc;
-    --diffBlob-deletion-fgColor-num: #f0f6fc;
-    --diffBlob-deletion-bgColor-num: #db6d284d;
-    --diffBlob-deletion-bgColor-line: #db6d2826;
-    --diffBlob-deletion-bgColor-word: #db6d2866;
-    --diffBlob-hunk-bgColor-num: #388bfd66;
+    --diffBlob-additionLine-fgColor: #f0f6fc;
+    --diffBlob-additionLine-bgColor: #388bfd26;
+    --diffBlob-additionWord-fgColor: #f0f6fc;
+    --diffBlob-additionWord-bgColor: #388bfd66;
+    --diffBlob-additionNum-fgColor: #f0f6fc;
+    --diffBlob-additionNum-bgColor: #58a6ff4d;
+    --diffBlob-deletionLine-fgColor: #f0f6fc;
+    --diffBlob-deletionLine-bgColor: #db6d2826;
+    --diffBlob-deletionWord-fgColor: #f0f6fc;
+    --diffBlob-deletionWord-bgColor: #db6d2866;
+    --diffBlob-deletionNum-fgColor: #f0f6fc;
+    --diffBlob-deletionNum-bgColor: #db6d284d;
+    --diffBlob-hunkLine-fgColor: #9198a1;
+    --diffBlob-hunkLine-bgColor: #212830;
+    --diffBlob-hunkNum-fgColor-rest: #f0f6fc;
+    --diffBlob-hunkNum-fgColor-hover: #ffffff;
+    --diffBlob-hunkNum-bgColor-rest: #2f3742;
+    --diffBlob-hunkNum-bgColor-hover: #656c76;
+    --diffBlob-emptyNum-bgColor: #151b23;
+    --diffBlob-emptyLine-bgColor: #151b23;
   --diffBlob-expander-iconColor: #9198a1;
   --codeMirror-fgColor: #f0f6fc;
   --codeMirror-bgColor: #0d1117;

/css/functional/themes/dark-dimmed.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-dimmed.css	2024-10-25 14:17:41.751665799 +0000
@@ -5,18 +5,27 @@
 --topicTag-borderColor: #00000000;
 --highlight-neutral-bgColor: #c6902666;
 --page-header-bgColor: #212830;
-  --diffBlob-addition-fgColor-text: #d1d7e0;
-  --diffBlob-addition-fgColor-num: #d1d7e0;
-  --diffBlob-addition-bgColor-num: #57ab5a4d;
-  --diffBlob-addition-bgColor-line: #46954a26;
-  --diffBlob-addition-bgColor-word: #46954a66;
-  --diffBlob-deletion-fgColor-text: #d1d7e0;
-  --diffBlob-deletion-fgColor-num: #d1d7e0;
-  --diffBlob-deletion-bgColor-num: #e5534b4d;
-  --diffBlob-deletion-bgColor-line: #e5534b26;
-  --diffBlob-deletion-bgColor-word: #e5534b66;
-  --diffBlob-hunk-bgColor-num: #4184e466;
-  --diffBlob-expander-iconColor: #d1d7e0;
+  --diffBlob-additionLine-fgColor: #d1d7e0;
+  --diffBlob-additionLine-bgColor: #46954a26;
+  --diffBlob-additionWord-fgColor: #d1d7e0;
+  --diffBlob-additionWord-bgColor: #46954a66;
+  --diffBlob-additionNum-fgColor: #d1d7e0;
+  --diffBlob-additionNum-bgColor: #57ab5a4d;
+  --diffBlob-deletionLine-fgColor: #d1d7e0;
+  --diffBlob-deletionLine-bgColor: #e5534b1a;
+  --diffBlob-deletionWord-fgColor: #d1d7e0;
+  --diffBlob-deletionWord-bgColor: #e5534b66;
+  --diffBlob-deletionNum-fgColor: #d1d7e0;
+  --diffBlob-deletionNum-bgColor: #e5534b4d;
+  --diffBlob-hunkLine-fgColor: #9198a1;
+  --diffBlob-hunkLine-bgColor: #4184e41a;
+  --diffBlob-hunkNum-fgColor-rest: #d1d7e0;
+  --diffBlob-hunkNum-fgColor-hover: #f0f6fc;
+  --diffBlob-hunkNum-bgColor-rest: #143d79;
+  --diffBlob-hunkNum-bgColor-hover: #316dca;
+  --diffBlob-emptyNum-bgColor: #262c36;
+  --diffBlob-emptyLine-bgColor: #262c36;
+  --diffBlob-expander-iconColor: #9198a1;
 --codeMirror-fgColor: #d1d7e0;
 --codeMirror-bgColor: #212830;
 --codeMirror-gutters-bgColor: #212830;
@@ -574,18 +583,27 @@
   --topicTag-borderColor: #00000000;
   --highlight-neutral-bgColor: #c6902666;
   --page-header-bgColor: #212830;
-    --diffBlob-addition-fgColor-text: #d1d7e0;
-    --diffBlob-addition-fgColor-num: #d1d7e0;
-    --diffBlob-addition-bgColor-num: #57ab5a4d;
-    --diffBlob-addition-bgColor-line: #46954a26;
-    --diffBlob-addition-bgColor-word: #46954a66;
-    --diffBlob-deletion-fgColor-text: #d1d7e0;
-    --diffBlob-deletion-fgColor-num: #d1d7e0;
-    --diffBlob-deletion-bgColor-num: #e5534b4d;
-    --diffBlob-deletion-bgColor-line: #e5534b26;
-    --diffBlob-deletion-bgColor-word: #e5534b66;
-    --diffBlob-hunk-bgColor-num: #4184e466;
-    --diffBlob-expander-iconColor: #d1d7e0;
+    --diffBlob-additionLine-fgColor: #d1d7e0;
+    --diffBlob-additionLine-bgColor: #46954a26;
+    --diffBlob-additionWord-fgColor: #d1d7e0;
+    --diffBlob-additionWord-bgColor: #46954a66;
+    --diffBlob-additionNum-fgColor: #d1d7e0;
+    --diffBlob-additionNum-bgColor: #57ab5a4d;
+    --diffBlob-deletionLine-fgColor: #d1d7e0;
+    --diffBlob-deletionLine-bgColor: #e5534b1a;
+    --diffBlob-deletionWord-fgColor: #d1d7e0;
+    --diffBlob-deletionWord-bgColor: #e5534b66;
+    --diffBlob-deletionNum-fgColor: #d1d7e0;
+    --diffBlob-deletionNum-bgColor: #e5534b4d;
+    --diffBlob-hunkLine-fgColor: #9198a1;
+    --diffBlob-hunkLine-bgColor: #4184e41a;
+    --diffBlob-hunkNum-fgColor-rest: #d1d7e0;
+    --diffBlob-hunkNum-fgColor-hover: #f0f6fc;
+    --diffBlob-hunkNum-bgColor-rest: #143d79;
+    --diffBlob-hunkNum-bgColor-hover: #316dca;
+    --diffBlob-emptyNum-bgColor: #262c36;
+    --diffBlob-emptyLine-bgColor: #262c36;
+    --diffBlob-expander-iconColor: #9198a1;
   --codeMirror-fgColor: #d1d7e0;
   --codeMirror-bgColor: #212830;
   --codeMirror-gutters-bgColor: #212830;

/css/functional/themes/dark-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-high-contrast.css	2024-10-25 14:17:44.527697411 +0000
@@ -5,17 +5,26 @@
 --topicTag-borderColor: #409eff;
 --highlight-neutral-bgColor: #f0b72f66;
 --page-header-bgColor: #010409;
-  --diffBlob-addition-fgColor-text: #ffffff;
-  --diffBlob-addition-fgColor-num: #ffffff;
-  --diffBlob-addition-bgColor-num: #28d7514d;
-  --diffBlob-addition-bgColor-line: #0ac74026;
-  --diffBlob-addition-bgColor-word: #006222;
-  --diffBlob-deletion-fgColor-text: #ffffff;
-  --diffBlob-deletion-fgColor-num: #ffffff;
-  --diffBlob-deletion-bgColor-num: #ff80804d;
-  --diffBlob-deletion-bgColor-line: #ff808026;
-  --diffBlob-deletion-bgColor-word: #ad0116;
-  --diffBlob-hunk-bgColor-num: #5cacff66;
+  --diffBlob-additionLine-fgColor: #ffffff;
+  --diffBlob-additionLine-bgColor: #0ac74033;
+  --diffBlob-additionWord-fgColor: #ffffff;
+  --diffBlob-additionWord-bgColor: #006222;
+  --diffBlob-additionNum-fgColor: #ffffff;
+  --diffBlob-additionNum-bgColor: #28d7514d;
+  --diffBlob-deletionLine-fgColor: #ffffff;
+  --diffBlob-deletionLine-bgColor: #ff808033;
+  --diffBlob-deletionWord-fgColor: #ffffff;
+  --diffBlob-deletionWord-bgColor: #ad0116;
+  --diffBlob-deletionNum-fgColor: #ffffff;
+  --diffBlob-deletionNum-bgColor: #ff80804d;
+  --diffBlob-hunkLine-fgColor: #b7bdc8;
+  --diffBlob-hunkLine-bgColor: #5cacff33;
+  --diffBlob-hunkNum-fgColor-rest: #ffffff;
+  --diffBlob-hunkNum-fgColor-hover: #ffffff;
+  --diffBlob-hunkNum-bgColor-rest: #5cacff66;
+  --diffBlob-hunkNum-bgColor-hover: #194fb1;
+  --diffBlob-emptyNum-bgColor: #151b23;
+  --diffBlob-emptyLine-bgColor: #151b23;
 --diffBlob-expander-iconColor: #ffffff;
 --codeMirror-fgColor: #ffffff;
 --codeMirror-bgColor: #010409;
@@ -574,17 +583,26 @@
   --topicTag-borderColor: #409eff;
   --highlight-neutral-bgColor: #f0b72f66;
   --page-header-bgColor: #010409;
-    --diffBlob-addition-fgColor-text: #ffffff;
-    --diffBlob-addition-fgColor-num: #ffffff;
-    --diffBlob-addition-bgColor-num: #28d7514d;
-    --diffBlob-addition-bgColor-line: #0ac74026;
-    --diffBlob-addition-bgColor-word: #006222;
-    --diffBlob-deletion-fgColor-text: #ffffff;
-    --diffBlob-deletion-fgColor-num: #ffffff;
-    --diffBlob-deletion-bgColor-num: #ff80804d;
-    --diffBlob-deletion-bgColor-line: #ff808026;
-    --diffBlob-deletion-bgColor-word: #ad0116;
-    --diffBlob-hunk-bgColor-num: #5cacff66;
+    --diffBlob-additionLine-fgColor: #ffffff;
+    --diffBlob-additionLine-bgColor: #0ac74033;
+    --diffBlob-additionWord-fgColor: #ffffff;
+    --diffBlob-additionWord-bgColor: #006222;
+    --diffBlob-additionNum-fgColor: #ffffff;
+    --diffBlob-additionNum-bgColor: #28d7514d;
+    --diffBlob-deletionLine-fgColor: #ffffff;
+    --diffBlob-deletionLine-bgColor: #ff808033;
+    --diffBlob-deletionWord-fgColor: #ffffff;
+    --diffBlob-deletionWord-bgColor: #ad0116;
+    --diffBlob-deletionNum-fgColor: #ffffff;
+    --diffBlob-deletionNum-bgColor: #ff80804d;
+    --diffBlob-hunkLine-fgColor: #b7bdc8;
+    --diffBlob-hunkLine-bgColor: #5cacff33;
+    --diffBlob-hunkNum-fgColor-rest: #ffffff;
+    --diffBlob-hunkNum-fgColor-hover: #ffffff;
+    --diffBlob-hunkNum-bgColor-rest: #5cacff66;
+    --diffBlob-hunkNum-bgColor-hover: #194fb1;
+    --diffBlob-emptyNum-bgColor: #151b23;
+    --diffBlob-emptyLine-bgColor: #151b23;
   --diffBlob-expander-iconColor: #ffffff;
   --codeMirror-fgColor: #ffffff;
   --codeMirror-bgColor: #010409;

/css/functional/themes/dark-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-tritanopia.css	2024-10-25 14:17:42.655676094 +0000
@@ -5,17 +5,26 @@
 --topicTag-borderColor: #00000000;
 --highlight-neutral-bgColor: #d2992266;
 --page-header-bgColor: #0d1117;
-  --diffBlob-addition-fgColor-text: #f0f6fc;
-  --diffBlob-addition-fgColor-num: #f0f6fc;
-  --diffBlob-addition-bgColor-num: #58a6ff4d;
-  --diffBlob-addition-bgColor-line: #388bfd26;
-  --diffBlob-addition-bgColor-word: #388bfd66;
-  --diffBlob-deletion-fgColor-text: #f0f6fc;
-  --diffBlob-deletion-fgColor-num: #f0f6fc;
-  --diffBlob-deletion-bgColor-num: #f851494d;
-  --diffBlob-deletion-bgColor-line: #f8514926;
-  --diffBlob-deletion-bgColor-word: #f8514966;
-  --diffBlob-hunk-bgColor-num: #388bfd66;
+  --diffBlob-additionLine-fgColor: #f0f6fc;
+  --diffBlob-additionLine-bgColor: #388bfd26;
+  --diffBlob-additionWord-fgColor: #f0f6fc;
+  --diffBlob-additionWord-bgColor: #388bfd66;
+  --diffBlob-additionNum-fgColor: #f0f6fc;
+  --diffBlob-additionNum-bgColor: #58a6ff4d;
+  --diffBlob-deletionLine-fgColor: #f0f6fc;
+  --diffBlob-deletionLine-bgColor: #f851491a;
+  --diffBlob-deletionWord-fgColor: #f0f6fc;
+  --diffBlob-deletionWord-bgColor: #f8514966;
+  --diffBlob-deletionNum-fgColor: #f0f6fc;
+  --diffBlob-deletionNum-bgColor: #f851494d;
+  --diffBlob-hunkLine-fgColor: #9198a1;
+  --diffBlob-hunkLine-bgColor: #212830;
+  --diffBlob-hunkNum-fgColor-rest: #f0f6fc;
+  --diffBlob-hunkNum-fgColor-hover: #ffffff;
+  --diffBlob-hunkNum-bgColor-rest: #2f3742;
+  --diffBlob-hunkNum-bgColor-hover: #656c76;
+  --diffBlob-emptyNum-bgColor: #151b23;
+  --diffBlob-emptyLine-bgColor: #151b23;
 --diffBlob-expander-iconColor: #9198a1;
 --codeMirror-fgColor: #f0f6fc;
 --codeMirror-bgColor: #0d1117;
@@ -574,17 +583,26 @@
   --topicTag-borderColor: #00000000;
   --highlight-neutral-bgColor: #d2992266;
   --page-header-bgColor: #0d1117;
-    --diffBlob-addition-fgColor-text: #f0f6fc;
-    --diffBlob-addition-fgColor-num: #f0f6fc;
-    --diffBlob-addition-bgColor-num: #58a6ff4d;
-    --diffBlob-addition-bgColor-line: #388bfd26;
-    --diffBlob-addition-bgColor-word: #388bfd66;
-    --diffBlob-deletion-fgColor-text: #f0f6fc;
-    --diffBlob-deletion-fgColor-num: #f0f6fc;
-    --diffBlob-deletion-bgColor-num: #f851494d;
-    --diffBlob-deletion-bgColor-line: #f8514926;
-    --diffBlob-deletion-bgColor-word: #f8514966;
-    --diffBlob-hunk-bgColor-num: #388bfd66;
+    --diffBlob-additionLine-fgColor: #f0f6fc;
+    --diffBlob-additionLine-bgColor: #388bfd26;
+    --diffBlob-additionWord-fgColor: #f0f6fc;
+    --diffBlob-additionWord-bgColor: #388bfd66;
+    --diffBlob-additionNum-fgColor: #f0f6fc;
+    --diffBlob-additionNum-bgColor: #58a6ff4d;
+    --diffBlob-deletionLine-fgColor: #f0f6fc;
+    --diffBlob-deletionLine-bgColor: #f851491a;
+    --diffBlob-deletionWord-fgColor: #f0f6fc;
+    --diffBlob-deletionWord-bgColor: #f8514966;
+    --diffBlob-deletionNum-fgColor: #f0f6fc;
+    --diffBlob-deletionNum-bgColor: #f851494d;
+    --diffBlob-hunkLine-fgColor: #9198a1;
+    --diffBlob-hunkLine-bgColor: #212830;
+    --diffBlob-hunkNum-fgColor-rest: #f0f6fc;
+    --diffBlob-hunkNum-fgColor-hover: #ffffff;
+    --diffBlob-hunkNum-bgColor-rest: #2f3742;
+    --diffBlob-hunkNum-bgColor-hover: #656c76;
+    --diffBlob-emptyNum-bgColor: #151b23;
+    --diffBlob-emptyLine-bgColor: #151b23;
   --diffBlob-expander-iconColor: #9198a1;
   --codeMirror-fgColor: #f0f6fc;
   --codeMirror-bgColor: #0d1117;

/css/functional/themes/dark.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark.css	2024-10-25 14:17:40.799654958 +0000
@@ -5,17 +5,26 @@
 --topicTag-borderColor: #00000000;
 --highlight-neutral-bgColor: #d2992266;
 --page-header-bgColor: #0d1117;
-  --diffBlob-addition-fgColor-text: #f0f6fc;
-  --diffBlob-addition-fgColor-num: #f0f6fc;
-  --diffBlob-addition-bgColor-num: #3fb9504d;
-  --diffBlob-addition-bgColor-line: #2ea04326;
-  --diffBlob-addition-bgColor-word: #2ea04366;
-  --diffBlob-deletion-fgColor-text: #f0f6fc;
-  --diffBlob-deletion-fgColor-num: #f0f6fc;
-  --diffBlob-deletion-bgColor-num: #f851494d;
-  --diffBlob-deletion-bgColor-line: #f8514926;
-  --diffBlob-deletion-bgColor-word: #f8514966;
-  --diffBlob-hunk-bgColor-num: #388bfd66;
+  --diffBlob-additionLine-fgColor: #f0f6fc;
+  --diffBlob-additionLine-bgColor: #2ea04326;
+  --diffBlob-additionWord-fgColor: #f0f6fc;
+  --diffBlob-additionWord-bgColor: #2ea04366;
+  --diffBlob-additionNum-fgColor: #f0f6fc;
+  --diffBlob-additionNum-bgColor: #3fb9504d;
+  --diffBlob-deletionLine-fgColor: #f0f6fc;
+  --diffBlob-deletionLine-bgColor: #f851491a;
+  --diffBlob-deletionWord-fgColor: #f0f6fc;
+  --diffBlob-deletionWord-bgColor: #f8514966;
+  --diffBlob-deletionNum-fgColor: #f0f6fc;
+  --diffBlob-deletionNum-bgColor: #f851494d;
+  --diffBlob-hunkLine-fgColor: #9198a1;
+  --diffBlob-hunkLine-bgColor: #388bfd1a;
+  --diffBlob-hunkNum-fgColor-rest: #f0f6fc;
+  --diffBlob-hunkNum-fgColor-hover: #ffffff;
+  --diffBlob-hunkNum-bgColor-rest: #0c2d6b;
+  --diffBlob-hunkNum-bgColor-hover: #1f6feb;
+  --diffBlob-emptyNum-bgColor: #151b23;
+  --diffBlob-emptyLine-bgColor: #151b23;
 --diffBlob-expander-iconColor: #9198a1;
 --codeMirror-fgColor: #f0f6fc;
 --codeMirror-bgColor: #0d1117;
@@ -574,17 +583,26 @@
   --topicTag-borderColor: #00000000;
   --highlight-neutral-bgColor: #d2992266;
   --page-header-bgColor: #0d1117;
-    --diffBlob-addition-fgColor-text: #f0f6fc;
-    --diffBlob-addition-fgColor-num: #f0f6fc;
-    --diffBlob-addition-bgColor-num: #3fb9504d;
-    --diffBlob-addition-bgColor-line: #2ea04326;
-    --diffBlob-addition-bgColor-word: #2ea04366;
-    --diffBlob-deletion-fgColor-text: #f0f6fc;
-    --diffBlob-deletion-fgColor-num: #f0f6fc;
-    --diffBlob-deletion-bgColor-num: #f851494d;
-    --diffBlob-deletion-bgColor-line: #f8514926;
-    --diffBlob-deletion-bgColor-word: #f8514966;
-    --diffBlob-hunk-bgColor-num: #388bfd66;
+    --diffBlob-additionLine-fgColor: #f0f6fc;
+    --diffBlob-additionLine-bgColor: #2ea04326;
+    --diffBlob-additionWord-fgColor: #f0f6fc;
+    --diffBlob-additionWord-bgColor: #2ea04366;
+    --diffBlob-additionNum-fgColor: #f0f6fc;
+    --diffBlob-additionNum-bgColor: #3fb9504d;
+    --diffBlob-deletionLine-fgColor: #f0f6fc;
+    --diffBlob-deletionLine-bgColor: #f851491a;
+    --diffBlob-deletionWord-fgColor: #f0f6fc;
+    --diffBlob-deletionWord-bgColor: #f8514966;
+    --diffBlob-deletionNum-fgColor: #f0f6fc;
+    --diffBlob-deletionNum-bgColor: #f851494d;
+    --diffBlob-hunkLine-fgColor: #9198a1;
+    --diffBlob-hunkLine-bgColor: #388bfd1a;
+    --diffBlob-hunkNum-fgColor-rest: #f0f6fc;
+    --diffBlob-hunkNum-fgColor-hover: #ffffff;
+    --diffBlob-hunkNum-bgColor-rest: #0c2d6b;
+    --diffBlob-hunkNum-bgColor-hover: #1f6feb;
+    --diffBlob-emptyNum-bgColor: #151b23;
+    --diffBlob-emptyLine-bgColor: #151b23;
   --diffBlob-expander-iconColor: #9198a1;
   --codeMirror-fgColor: #f0f6fc;
   --codeMirror-bgColor: #0d1117;

/css/functional/themes/light-colorblind.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-colorblind.css	2024-10-25 14:17:38.467628450 +0000
@@ -5,17 +5,26 @@
 --topicTag-borderColor: #ffffff00;
 --highlight-neutral-bgColor: #fff8c5;
 --page-header-bgColor: #f6f8fa;
-  --diffBlob-addition-fgColor-text: #1f2328;
-  --diffBlob-addition-fgColor-num: #1f2328;
-  --diffBlob-addition-bgColor-num: #54aeff66;
-  --diffBlob-addition-bgColor-line: #ddf4ff80;
-  --diffBlob-addition-bgColor-word: #54aeff66;
-  --diffBlob-deletion-fgColor-text: #1f2328;
-  --diffBlob-deletion-fgColor-num: #1f2328;
-  --diffBlob-deletion-bgColor-num: #fb8f4466;
-  --diffBlob-deletion-bgColor-line: #fff1e580;
-  --diffBlob-deletion-bgColor-word: #ffb77c80;
-  --diffBlob-hunk-bgColor-num: #54aeff66;
+  --diffBlob-additionLine-fgColor: #1f2328;
+  --diffBlob-additionLine-bgColor: #ddf4ff;
+  --diffBlob-additionWord-fgColor: #1f2328;
+  --diffBlob-additionWord-bgColor: #b6e3ff;
+  --diffBlob-additionNum-fgColor: #1f2328;
+  --diffBlob-additionNum-bgColor: #b6e3ff;
+  --diffBlob-deletionLine-fgColor: #1f2328;
+  --diffBlob-deletionLine-bgColor: #fff1e5;
+  --diffBlob-deletionWord-fgColor: #1f2328;
+  --diffBlob-deletionWord-bgColor: #ffd8b5;
+  --diffBlob-deletionNum-fgColor: #1f2328;
+  --diffBlob-deletionNum-bgColor: #ffd8b5;
+  --diffBlob-hunkLine-bgColor: #f6f8fa;
+  --diffBlob-hunkLine-fgColor: #59636e;
+  --diffBlob-hunkNum-fgColor-rest: #1f2328;
+  --diffBlob-hunkNum-fgColor-hover: #1f2328;
+  --diffBlob-hunkNum-bgColor-rest: #e6eaef;
+  --diffBlob-hunkNum-bgColor-hover: #c8d1da;
+  --diffBlob-emptyNum-bgColor: #f6f8fa;
+  --diffBlob-emptyLine-bgColor: #f6f8fa;
 --diffBlob-expander-iconColor: #59636e;
 --codeMirror-fgColor: #1f2328;
 --codeMirror-bgColor: #ffffff;
@@ -574,17 +583,26 @@
   --topicTag-borderColor: #ffffff00;
   --highlight-neutral-bgColor: #fff8c5;
   --page-header-bgColor: #f6f8fa;
-    --diffBlob-addition-fgColor-text: #1f2328;
-    --diffBlob-addition-fgColor-num: #1f2328;
-    --diffBlob-addition-bgColor-num: #54aeff66;
-    --diffBlob-addition-bgColor-line: #ddf4ff80;
-    --diffBlob-addition-bgColor-word: #54aeff66;
-    --diffBlob-deletion-fgColor-text: #1f2328;
-    --diffBlob-deletion-fgColor-num: #1f2328;
-    --diffBlob-deletion-bgColor-num: #fb8f4466;
-    --diffBlob-deletion-bgColor-line: #fff1e580;
-    --diffBlob-deletion-bgColor-word: #ffb77c80;
-    --diffBlob-hunk-bgColor-num: #54aeff66;
+    --diffBlob-additionLine-fgColor: #1f2328;
+    --diffBlob-additionLine-bgColor: #ddf4ff;
+    --diffBlob-additionWord-fgColor: #1f2328;
+    --diffBlob-additionWord-bgColor: #b6e3ff;
+    --diffBlob-additionNum-fgColor: #1f2328;
+    --diffBlob-additionNum-bgColor: #b6e3ff;
+    --diffBlob-deletionLine-fgColor: #1f2328;
+    --diffBlob-deletionLine-bgColor: #fff1e5;
+    --diffBlob-deletionWord-fgColor: #1f2328;
+    --diffBlob-deletionWord-bgColor: #ffd8b5;
+    --diffBlob-deletionNum-fgColor: #1f2328;
+    --diffBlob-deletionNum-bgColor: #ffd8b5;
+    --diffBlob-hunkLine-bgColor: #f6f8fa;
+    --diffBlob-hunkLine-fgColor: #59636e;
+    --diffBlob-hunkNum-fgColor-rest: #1f2328;
+    --diffBlob-hunkNum-fgColor-hover: #1f2328;
+    --diffBlob-hunkNum-bgColor-rest: #e6eaef;
+    --diffBlob-hunkNum-bgColor-hover: #c8d1da;
+    --diffBlob-emptyNum-bgColor: #f6f8fa;
+    --diffBlob-emptyLine-bgColor: #f6f8fa;
   --diffBlob-expander-iconColor: #59636e;
   --codeMirror-fgColor: #1f2328;
   --codeMirror-bgColor: #ffffff;

/css/functional/themes/light-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-high-contrast.css	2024-10-25 14:17:39.623641566 +0000
@@ -5,18 +5,27 @@
 --topicTag-borderColor: #0349b4;
 --highlight-neutral-bgColor: #fcf7be;
 --page-header-bgColor: #e6eaef;
-  --diffBlob-addition-fgColor-text: #ffffff;
-  --diffBlob-addition-fgColor-num: #010409;
-  --diffBlob-addition-bgColor-num: #c2f9cd;
-  --diffBlob-addition-bgColor-line: #d2fedb;
-  --diffBlob-addition-bgColor-word: #117f32;
-  --diffBlob-deletion-fgColor-text: #ffffff;
-  --diffBlob-deletion-fgColor-num: #010409;
-  --diffBlob-deletion-bgColor-num: #ffc1bc;
-  --diffBlob-deletion-bgColor-line: #fff0ee;
-  --diffBlob-deletion-bgColor-word: #a0111f;
-  --diffBlob-hunk-bgColor-num: #9cd7ff;
-  --diffBlob-expander-iconColor: #454c54;
+  --diffBlob-additionLine-fgColor: #010409;
+  --diffBlob-additionLine-bgColor: #d2fedb;
+  --diffBlob-additionWord-fgColor: #ffffff;
+  --diffBlob-additionWord-bgColor: #055d20;
+  --diffBlob-additionNum-fgColor: #010409;
+  --diffBlob-additionNum-bgColor: #82e596;
+  --diffBlob-deletionLine-fgColor: #010409;
+  --diffBlob-deletionLine-bgColor: #fff0ee;
+  --diffBlob-deletionWord-fgColor: #ffffff;
+  --diffBlob-deletionWord-bgColor: #a0111f;
+  --diffBlob-deletionNum-fgColor: #010409;
+  --diffBlob-deletionNum-bgColor: #ffc1bc;
+  --diffBlob-hunkLine-bgColor: #dff7ff;
+  --diffBlob-hunkLine-fgColor: #454c54;
+  --diffBlob-hunkNum-fgColor-rest: #010409;
+  --diffBlob-hunkNum-fgColor-hover: #ffffff;
+  --diffBlob-hunkNum-bgColor-rest: #9cd7ff;
+  --diffBlob-hunkNum-bgColor-hover: #0349b4;
+  --diffBlob-emptyNum-bgColor: #e6eaef;
+  --diffBlob-emptyLine-bgColor: #e6eaef;
+  --diffBlob-expander-iconColor: #010409;
 --codeMirror-fgColor: #010409;
 --codeMirror-bgColor: #ffffff;
 --codeMirror-gutters-bgColor: #ffffff;
@@ -574,18 +583,27 @@
   --topicTag-borderColor: #0349b4;
   --highlight-neutral-bgColor: #fcf7be;
   --page-header-bgColor: #e6eaef;
-    --diffBlob-addition-fgColor-text: #ffffff;
-    --diffBlob-addition-fgColor-num: #010409;
-    --diffBlob-addition-bgColor-num: #c2f9cd;
-    --diffBlob-addition-bgColor-line: #d2fedb;
-    --diffBlob-addition-bgColor-word: #117f32;
-    --diffBlob-deletion-fgColor-text: #ffffff;
-    --diffBlob-deletion-fgColor-num: #010409;
-    --diffBlob-deletion-bgColor-num: #ffc1bc;
-    --diffBlob-deletion-bgColor-line: #fff0ee;
-    --diffBlob-deletion-bgColor-word: #a0111f;
-    --diffBlob-hunk-bgColor-num: #9cd7ff;
-    --diffBlob-expander-iconColor: #454c54;
+    --diffBlob-additionLine-fgColor: #010409;
+    --diffBlob-additionLine-bgColor: #d2fedb;
+    --diffBlob-additionWord-fgColor: #ffffff;
+    --diffBlob-additionWord-bgColor: #055d20;
+    --diffBlob-additionNum-fgColor: #010409;
+    --diffBlob-additionNum-bgColor: #82e596;
+    --diffBlob-deletionLine-fgColor: #010409;
+    --diffBlob-deletionLine-bgColor: #fff0ee;
+    --diffBlob-deletionWord-fgColor: #ffffff;
+    --diffBlob-deletionWord-bgColor: #a0111f;
+    --diffBlob-deletionNum-fgColor: #010409;
+    --diffBlob-deletionNum-bgColor: #ffc1bc;
+    --diffBlob-hunkLine-bgColor: #dff7ff;
+    --diffBlob-hunkLine-fgColor: #454c54;
+    --diffBlob-hunkNum-fgColor-rest: #010409;
+    --diffBlob-hunkNum-fgColor-hover: #ffffff;
+    --diffBlob-hunkNum-bgColor-rest: #9cd7ff;
+    --diffBlob-hunkNum-bgColor-hover: #0349b4;
+    --diffBlob-emptyNum-bgColor: #e6eaef;
+    --diffBlob-emptyLine-bgColor: #e6eaef;
+    --diffBlob-expander-iconColor: #010409;
   --codeMirror-fgColor: #010409;
   --codeMirror-bgColor: #ffffff;
   --codeMirror-gutters-bgColor: #ffffff;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-tritanopia.css	2024-10-25 14:17:37.459617030 +0000
@@ -5,17 +5,26 @@
 --topicTag-borderColor: #ffffff00;
 --highlight-neutral-bgColor: #fff8c5;
 --page-header-bgColor: #f6f8fa;
-  --diffBlob-addition-fgColor-text: #1f2328;
-  --diffBlob-addition-fgColor-num: #1f2328;
-  --diffBlob-addition-bgColor-num: #d5f1ff;
-  --diffBlob-addition-bgColor-line: #ddf4ff;
-  --diffBlob-addition-bgColor-word: #b6e3ff;
-  --diffBlob-deletion-fgColor-text: #1f2328;
-  --diffBlob-deletion-fgColor-num: #1f2328;
-  --diffBlob-deletion-bgColor-num: #ffcecb;
-  --diffBlob-deletion-bgColor-line: #ffebe9;
-  --diffBlob-deletion-bgColor-word: #ff818266;
-  --diffBlob-hunk-bgColor-num: #54aeff66;
+  --diffBlob-additionLine-fgColor: #1f2328;
+  --diffBlob-additionLine-bgColor: #ddf4ff;
+  --diffBlob-additionWord-fgColor: #1f2328;
+  --diffBlob-additionWord-bgColor: #b6e3ff;
+  --diffBlob-additionNum-fgColor: #1f2328;
+  --diffBlob-additionNum-bgColor: #b6e3ff;
+  --diffBlob-deletionLine-fgColor: #1f2328;
+  --diffBlob-deletionLine-bgColor: #ffebe9;
+  --diffBlob-deletionWord-fgColor: #1f2328;
+  --diffBlob-deletionWord-bgColor: #ffcecb;
+  --diffBlob-deletionNum-fgColor: #1f2328;
+  --diffBlob-deletionNum-bgColor: #ffcecb;
+  --diffBlob-hunkLine-bgColor: #f6f8fa;
+  --diffBlob-hunkLine-fgColor: #59636e;
+  --diffBlob-hunkNum-fgColor-rest: #1f2328;
+  --diffBlob-hunkNum-fgColor-hover: #1f2328;
+  --diffBlob-hunkNum-bgColor-rest: #e6eaef;
+  --diffBlob-hunkNum-bgColor-hover: #c8d1da;
+  --diffBlob-emptyNum-bgColor: #f6f8fa;
+  --diffBlob-emptyLine-bgColor: #f6f8fa;
 --diffBlob-expander-iconColor: #59636e;
 --codeMirror-fgColor: #1f2328;
 --codeMirror-bgColor: #ffffff;
@@ -574,17 +583,26 @@
   --topicTag-borderColor: #ffffff00;
   --highlight-neutral-bgColor: #fff8c5;
   --page-header-bgColor: #f6f8fa;
-    --diffBlob-addition-fgColor-text: #1f2328;
-    --diffBlob-addition-fgColor-num: #1f2328;
-    --diffBlob-addition-bgColor-num: #d5f1ff;
-    --diffBlob-addition-bgColor-line: #ddf4ff;
-    --diffBlob-addition-bgColor-word: #b6e3ff;
-    --diffBlob-deletion-fgColor-text: #1f2328;
-    --diffBlob-deletion-fgColor-num: #1f2328;
-    --diffBlob-deletion-bgColor-num: #ffcecb;
-    --diffBlob-deletion-bgColor-line: #ffebe9;
-    --diffBlob-deletion-bgColor-word: #ff818266;
-    --diffBlob-hunk-bgColor-num: #54aeff66;
+    --diffBlob-additionLine-fgColor: #1f2328;
+    --diffBlob-additionLine-bgColor: #ddf4ff;
+    --diffBlob-additionWord-fgColor: #1f2328;
+    --diffBlob-additionWord-bgColor: #b6e3ff;
+    --diffBlob-additionNum-fgColor: #1f2328;
+    --diffBlob-additionNum-bgColor: #b6e3ff;
+    --diffBlob-deletionLine-fgColor: #1f2328;
+    --diffBlob-deletionLine-bgColor: #ffebe9;
+    --diffBlob-deletionWord-fgColor: #1f2328;
+    --diffBlob-deletionWord-bgColor: #ffcecb;
+    --diffBlob-deletionNum-fgColor: #1f2328;
+    --diffBlob-deletionNum-bgColor: #ffcecb;
+    --diffBlob-hunkLine-bgColor: #f6f8fa;
+    --diffBlob-hunkLine-fgColor: #59636e;
+    --diffBlob-hunkNum-fgColor-rest: #1f2328;
+    --diffBlob-hunkNum-fgColor-hover: #1f2328;
+    --diffBlob-hunkNum-bgColor-rest: #e6eaef;
+    --diffBlob-hunkNum-bgColor-hover: #c8d1da;
+    --diffBlob-emptyNum-bgColor: #f6f8fa;
+    --diffBlob-emptyLine-bgColor: #f6f8fa;
   --diffBlob-expander-iconColor: #59636e;
   --codeMirror-fgColor: #1f2328;
   --codeMirror-bgColor: #ffffff;

/css/functional/themes/light.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light.css	2024-10-25 14:17:35.739597544 +0000
@@ -5,17 +5,26 @@
 --topicTag-borderColor: #ffffff00;
 --highlight-neutral-bgColor: #fff8c5;
 --page-header-bgColor: #f6f8fa;
-  --diffBlob-addition-fgColor-text: #1f2328;
-  --diffBlob-addition-fgColor-num: #1f2328;
-  --diffBlob-addition-bgColor-num: #d1f8d9;
-  --diffBlob-addition-bgColor-line: #dafbe1;
-  --diffBlob-addition-bgColor-word: #aceebb;
-  --diffBlob-deletion-fgColor-text: #1f2328;
-  --diffBlob-deletion-fgColor-num: #1f2328;
-  --diffBlob-deletion-bgColor-num: #ffcecb;
-  --diffBlob-deletion-bgColor-line: #ffebe9;
-  --diffBlob-deletion-bgColor-word: #ff818266;
-  --diffBlob-hunk-bgColor-num: #54aeff66;
+  --diffBlob-additionLine-fgColor: #1f2328;
+  --diffBlob-additionLine-bgColor: #dafbe1;
+  --diffBlob-additionWord-fgColor: #1f2328;
+  --diffBlob-additionWord-bgColor: #aceebb;
+  --diffBlob-additionNum-fgColor: #1f2328;
+  --diffBlob-additionNum-bgColor: #aceebb;
+  --diffBlob-deletionLine-fgColor: #1f2328;
+  --diffBlob-deletionLine-bgColor: #ffebe9;
+  --diffBlob-deletionWord-fgColor: #1f2328;
+  --diffBlob-deletionWord-bgColor: #ffcecb;
+  --diffBlob-deletionNum-fgColor: #1f2328;
+  --diffBlob-deletionNum-bgColor: #ffcecb;
+  --diffBlob-hunkLine-bgColor: #ddf4ff;
+  --diffBlob-hunkLine-fgColor: #59636e;
+  --diffBlob-hunkNum-fgColor-rest: #1f2328;
+  --diffBlob-hunkNum-fgColor-hover: #ffffff;
+  --diffBlob-hunkNum-bgColor-rest: #b6e3ff;
+  --diffBlob-hunkNum-bgColor-hover: #0969da;
+  --diffBlob-emptyNum-bgColor: #f6f8fa;
+  --diffBlob-emptyLine-bgColor: #f6f8fa;
 --diffBlob-expander-iconColor: #59636e;
 --codeMirror-fgColor: #1f2328;
 --codeMirror-bgColor: #ffffff;
@@ -574,17 +583,26 @@
   --topicTag-borderColor: #ffffff00;
   --highlight-neutral-bgColor: #fff8c5;
   --page-header-bgColor: #f6f8fa;
-    --diffBlob-addition-fgColor-text: #1f2328;
-    --diffBlob-addition-fgColor-num: #1f2328;
-    --diffBlob-addition-bgColor-num: #d1f8d9;
-    --diffBlob-addition-bgColor-line: #dafbe1;
-    --diffBlob-addition-bgColor-word: #aceebb;
-    --diffBlob-deletion-fgColor-text: #1f2328;
-    --diffBlob-deletion-fgColor-num: #1f2328;
-    --diffBlob-deletion-bgColor-num: #ffcecb;
-    --diffBlob-deletion-bgColor-line: #ffebe9;
-    --diffBlob-deletion-bgColor-word: #ff818266;
-    --diffBlob-hunk-bgColor-num: #54aeff66;
+    --diffBlob-additionLine-fgColor: #1f2328;
+    --diffBlob-additionLine-bgColor: #dafbe1;
+    --diffBlob-additionWord-fgColor: #1f2328;
+    --diffBlob-additionWord-bgColor: #aceebb;
+    --diffBlob-additionNum-fgColor: #1f2328;
+    --diffBlob-additionNum-bgColor: #aceebb;
+    --diffBlob-deletionLine-fgColor: #1f2328;
+    --diffBlob-deletionLine-bgColor: #ffebe9;
+    --diffBlob-deletionWord-fgColor: #1f2328;
+    --diffBlob-deletionWord-bgColor: #ffcecb;
+    --diffBlob-deletionNum-fgColor: #1f2328;
+    --diffBlob-deletionNum-bgColor: #ffcecb;
+    --diffBlob-hunkLine-bgColor: #ddf4ff;
+    --diffBlob-hunkLine-fgColor: #59636e;
+    --diffBlob-hunkNum-fgColor-rest: #1f2328;
+    --diffBlob-hunkNum-fgColor-hover: #ffffff;
+    --diffBlob-hunkNum-bgColor-rest: #b6e3ff;
+    --diffBlob-hunkNum-bgColor-hover: #0969da;
+    --diffBlob-emptyNum-bgColor: #f6f8fa;
+    --diffBlob-emptyLine-bgColor: #f6f8fa;
   --diffBlob-expander-iconColor: #59636e;
   --codeMirror-fgColor: #1f2328;
   --codeMirror-bgColor: #ffffff;

@lukasoppermann lukasoppermann force-pushed the diffBlob branch 2 times, most recently from 04bd6f5 to 0fbe73b Compare October 7, 2024 12:57
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 7, 2024 12:58 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 7, 2024 12:59 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 7, 2024 12:59 Inactive
langermank
langermank reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about leaving diffBlob-hunk-bgColor-num in for now so that this isn't a breaking change, and adding the rest and hover? Then we can remove the usages first.

src/tokens/functional/color/dark/app-dark.json5 Outdated Show resolved Hide resolved
src/tokens/functional/color/dark/app-dark.json5 Outdated Show resolved Hide resolved
src/tokens/functional/color/dark/app-dark.json5 Outdated Show resolved Hide resolved
src/tokens/functional/color/dark/app-dark.json5 Outdated Show resolved Hide resolved
src/tokens/functional/color/dark/app-dark.json5 Outdated Show resolved Hide resolved
src/tokens/functional/color/dark/app-dark.json5 Outdated Show resolved Hide resolved
src/tokens/functional/color/dark/app-dark.json5 Outdated Show resolved Hide resolved
@langermank langermank added the update snapshots Update visual regression test snapshots label Oct 7, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Oct 7, 2024
@primer primer bot temporarily deployed to github-pages October 7, 2024 21:48 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 7, 2024 21:49 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 25, 2024 10:55 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 25, 2024 10:58 Inactive
@lukasoppermann lukasoppermann added the update snapshots Update visual regression test snapshots label Oct 25, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Oct 25, 2024
@primer primer bot temporarily deployed to github-pages October 25, 2024 11:53 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 25, 2024 11:53 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 25, 2024 12:11 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 25, 2024 12:51 Inactive
@github-actions GitHub Actions
Copy link
Contributor

undefined

undefined

→ Detailsundefined

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

undefined

undefined

→ Detailsundefined

@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 25, 2024 12:59 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 25, 2024 14:17 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) October 25, 2024 14:19 Inactive
@lukasoppermann lukasoppermann merged commit 08186e7 into main Oct 25, 2024
26 checks passed
@lukasoppermann lukasoppermann deleted the diffBlob branch October 25, 2024 14:26
@primer primer bot mentioned this pull request Oct 25, 2024
Merged
This was referenced Nov 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@six7 six7 Awaiting requested review from six7

@langermank langermank Awaiting requested review from langermank

Assignees

@lukasoppermann lukasoppermann

Labels
primitives
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasoppermann @langermank