-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallbacks for postCss #654
Conversation
🦋 Changeset detectedLatest commit: be483ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Variables changedNo variables changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is AMAZING! THANK YOU!
I don't mind if you want to leave the color files in, but we won't use it for now. We only need color fallbacks to test the new color tokens against the existing tokens, meaning we use another CSS var in the fallback instead of a raw value.
To use raw colors, we would need to configure the PostCSS plugin to respect themes. I don't think we need that right now :)
@langermank in this case I will see if I can easily remove colors (should be fine). I am not a big fan of adding unused files. 👍 |
* fallbacks for postCss * added changeset * rm fallbacks for themes
Summary
This adds the fallback json files for PostCss
Output
All files are output as they are apart from color, which are combined to themes.
E.g.
base/size/size.json
base/typography/typography.json
functional/size/border.json
base/size.json
Questions