Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bgColor-neutral-muted #739

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix bgColor-neutral-muted #739

merged 2 commits into from
Sep 26, 2023

Conversation

lukasoppermann
Copy link
Contributor

Summary

Improve bgColor-neutral-muted contrast

@lukasoppermann lukasoppermann requested a review from a team as a code owner September 26, 2023 08:30
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 6d725c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

Variables changed 
No variables changed

@github-actions
Copy link
Contributor

Design Token Diff

/css/functional/themes/dark-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-colorblind.css	2023-09-26 08:31:35.140420567 +0000
@@ -23,7 +23,7 @@
 --codeMirror-lineNumber-fgColor: #7d8590;
 --codeMirror-cursor-fgColor: #e6edf3;
 --codeMirror-selection-bgColor: #388bfd66;
-  --codeMirror-activeline-bgColor: #6e768126;
+  --codeMirror-activeline-bgColor: #6e768166;
 --codeMirror-matchingBracket-fgColor: #e6edf3;
 --codeMirror-lines-bgColor: #0d1117;
 --codeMirror-syntax-fgColor-comment: #8b949e;
@@ -220,7 +220,7 @@
 --bgColor-inverse: #ffffff;
 --bgColor-disabled: #161b22;
 --bgColor-transparent: #00000000;
-  --bgColor-neutral-muted: #6e768126;
+  --bgColor-neutral-muted: #6e768166;
 --bgColor-neutral-emphasis: #6e7681;
 --bgColor-accent-muted: #388bfd1a;
 --bgColor-accent-emphasis: #1f6feb;
@@ -440,7 +440,7 @@
   --codeMirror-lineNumber-fgColor: #7d8590;
   --codeMirror-cursor-fgColor: #e6edf3;
   --codeMirror-selection-bgColor: #388bfd66;
-    --codeMirror-activeline-bgColor: #6e768126;
+    --codeMirror-activeline-bgColor: #6e768166;
   --codeMirror-matchingBracket-fgColor: #e6edf3;
   --codeMirror-lines-bgColor: #0d1117;
   --codeMirror-syntax-fgColor-comment: #8b949e;
@@ -637,7 +637,7 @@
   --bgColor-inverse: #ffffff;
   --bgColor-disabled: #161b22;
   --bgColor-transparent: #00000000;
-    --bgColor-neutral-muted: #6e768126;
+    --bgColor-neutral-muted: #6e768166;
   --bgColor-neutral-emphasis: #6e7681;
   --bgColor-accent-muted: #388bfd1a;
   --bgColor-accent-emphasis: #1f6feb;

/css/functional/themes/dark-dimmed.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-dimmed.css	2023-09-26 08:31:34.012414154 +0000
@@ -23,7 +23,7 @@
 --codeMirror-lineNumber-fgColor: #6d7986;
 --codeMirror-cursor-fgColor: #c5d1de;
 --codeMirror-selection-bgColor: #4184e466;
-  --codeMirror-activeline-bgColor: #636e7b26;
+  --codeMirror-activeline-bgColor: #636e7b66;
 --codeMirror-matchingBracket-fgColor: #c5d1de;
 --codeMirror-lines-bgColor: #22272e;
 --codeMirror-syntax-fgColor-comment: #768390;
@@ -220,7 +220,7 @@
 --bgColor-inverse: #cdd9e5;
 --bgColor-disabled: #2d333b;
 --bgColor-transparent: #00000000;
-  --bgColor-neutral-muted: #636e7b26;
+  --bgColor-neutral-muted: #636e7b66;
 --bgColor-neutral-emphasis: #636e7b;
 --bgColor-accent-muted: #4184e41a;
 --bgColor-accent-emphasis: #316dca;
@@ -440,7 +440,7 @@
   --codeMirror-lineNumber-fgColor: #6d7986;
   --codeMirror-cursor-fgColor: #c5d1de;
   --codeMirror-selection-bgColor: #4184e466;
-    --codeMirror-activeline-bgColor: #636e7b26;
+    --codeMirror-activeline-bgColor: #636e7b66;
   --codeMirror-matchingBracket-fgColor: #c5d1de;
   --codeMirror-lines-bgColor: #22272e;
   --codeMirror-syntax-fgColor-comment: #768390;
@@ -637,7 +637,7 @@
   --bgColor-inverse: #cdd9e5;
   --bgColor-disabled: #2d333b;
   --bgColor-transparent: #00000000;
-    --bgColor-neutral-muted: #636e7b26;
+    --bgColor-neutral-muted: #636e7b66;
   --bgColor-neutral-emphasis: #636e7b;
   --bgColor-accent-muted: #4184e41a;
   --bgColor-accent-emphasis: #316dca;

/css/functional/themes/dark-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-high-contrast.css	2023-09-26 08:31:35.704423773 +0000
@@ -23,7 +23,7 @@
 --codeMirror-lineNumber-fgColor: #f0f3f6;
 --codeMirror-cursor-fgColor: #fbfcfd;
 --codeMirror-selection-bgColor: #409eff66;
-  --codeMirror-activeline-bgColor: #9ea7b326;
+  --codeMirror-activeline-bgColor: #9ea7b366;
 --codeMirror-matchingBracket-fgColor: #fbfcfd;
 --codeMirror-lines-bgColor: #0a0c10;
 --codeMirror-syntax-fgColor-comment: #bdc4cc;
@@ -220,7 +220,7 @@
 --bgColor-inverse: #ffffff;
 --bgColor-disabled: #272b33;
 --bgColor-transparent: #00000000;
-  --bgColor-neutral-muted: #9ea7b326;
+  --bgColor-neutral-muted: #9ea7b366;
 --bgColor-neutral-emphasis: #9ea7b3;
 --bgColor-accent-muted: #409eff1a;
 --bgColor-accent-emphasis: #409eff;
@@ -440,7 +440,7 @@
   --codeMirror-lineNumber-fgColor: #f0f3f6;
   --codeMirror-cursor-fgColor: #fbfcfd;
   --codeMirror-selection-bgColor: #409eff66;
-    --codeMirror-activeline-bgColor: #9ea7b326;
+    --codeMirror-activeline-bgColor: #9ea7b366;
   --codeMirror-matchingBracket-fgColor: #fbfcfd;
   --codeMirror-lines-bgColor: #0a0c10;
   --codeMirror-syntax-fgColor-comment: #bdc4cc;
@@ -637,7 +637,7 @@
   --bgColor-inverse: #ffffff;
   --bgColor-disabled: #272b33;
   --bgColor-transparent: #00000000;
-    --bgColor-neutral-muted: #9ea7b326;
+    --bgColor-neutral-muted: #9ea7b366;
   --bgColor-neutral-emphasis: #9ea7b3;
   --bgColor-accent-muted: #409eff1a;
   --bgColor-accent-emphasis: #409eff;

/css/functional/themes/dark-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-tritanopia.css	2023-09-26 08:31:34.560417270 +0000
@@ -23,7 +23,7 @@
 --codeMirror-lineNumber-fgColor: #7d8590;
 --codeMirror-cursor-fgColor: #e6edf3;
 --codeMirror-selection-bgColor: #388bfd66;
-  --codeMirror-activeline-bgColor: #6e768126;
+  --codeMirror-activeline-bgColor: #6e768166;
 --codeMirror-matchingBracket-fgColor: #e6edf3;
 --codeMirror-lines-bgColor: #0d1117;
 --codeMirror-syntax-fgColor-comment: #8b949e;
@@ -220,7 +220,7 @@
 --bgColor-inverse: #ffffff;
 --bgColor-disabled: #161b22;
 --bgColor-transparent: #00000000;
-  --bgColor-neutral-muted: #6e768126;
+  --bgColor-neutral-muted: #6e768166;
 --bgColor-neutral-emphasis: #6e7681;
 --bgColor-accent-muted: #388bfd1a;
 --bgColor-accent-emphasis: #1f6feb;
@@ -440,7 +440,7 @@
   --codeMirror-lineNumber-fgColor: #7d8590;
   --codeMirror-cursor-fgColor: #e6edf3;
   --codeMirror-selection-bgColor: #388bfd66;
-    --codeMirror-activeline-bgColor: #6e768126;
+    --codeMirror-activeline-bgColor: #6e768166;
   --codeMirror-matchingBracket-fgColor: #e6edf3;
   --codeMirror-lines-bgColor: #0d1117;
   --codeMirror-syntax-fgColor-comment: #8b949e;
@@ -637,7 +637,7 @@
   --bgColor-inverse: #ffffff;
   --bgColor-disabled: #161b22;
   --bgColor-transparent: #00000000;
-    --bgColor-neutral-muted: #6e768126;
+    --bgColor-neutral-muted: #6e768166;
   --bgColor-neutral-emphasis: #6e7681;
   --bgColor-accent-muted: #388bfd1a;
   --bgColor-accent-emphasis: #1f6feb;

/css/functional/themes/dark.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark.css	2023-09-26 08:31:33.232409811 +0000
@@ -23,7 +23,7 @@
 --codeMirror-lineNumber-fgColor: #7d8590;
 --codeMirror-cursor-fgColor: #e6edf3;
 --codeMirror-selection-bgColor: #388bfd66;
-  --codeMirror-activeline-bgColor: #6e768126;
+  --codeMirror-activeline-bgColor: #6e768166;
 --codeMirror-matchingBracket-fgColor: #e6edf3;
 --codeMirror-lines-bgColor: #0d1117;
 --codeMirror-syntax-fgColor-comment: #8b949e;
@@ -220,7 +220,7 @@
 --bgColor-inverse: #ffffff;
 --bgColor-disabled: #161b22;
 --bgColor-transparent: #00000000;
-  --bgColor-neutral-muted: #6e768126;
+  --bgColor-neutral-muted: #6e768166;
 --bgColor-neutral-emphasis: #6e7681;
 --bgColor-accent-muted: #388bfd1a;
 --bgColor-accent-emphasis: #1f6feb;
@@ -440,7 +440,7 @@
   --codeMirror-lineNumber-fgColor: #7d8590;
   --codeMirror-cursor-fgColor: #e6edf3;
   --codeMirror-selection-bgColor: #388bfd66;
-    --codeMirror-activeline-bgColor: #6e768126;
+    --codeMirror-activeline-bgColor: #6e768166;
   --codeMirror-matchingBracket-fgColor: #e6edf3;
   --codeMirror-lines-bgColor: #0d1117;
   --codeMirror-syntax-fgColor-comment: #8b949e;
@@ -637,7 +637,7 @@
   --bgColor-inverse: #ffffff;
   --bgColor-disabled: #161b22;
   --bgColor-transparent: #00000000;
-    --bgColor-neutral-muted: #6e768126;
+    --bgColor-neutral-muted: #6e768166;
   --bgColor-neutral-emphasis: #6e7681;
   --bgColor-accent-muted: #388bfd1a;
   --bgColor-accent-emphasis: #1f6feb;

/css/functional/themes/light-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-colorblind.css	2023-09-26 08:31:32.016403182 +0000
@@ -23,7 +23,7 @@
 --codeMirror-lineNumber-fgColor: #636c76;
 --codeMirror-cursor-fgColor: #1f2328;
 --codeMirror-selection-bgColor: #54aeff66;
-  --codeMirror-activeline-bgColor: #eaeef280;
+  --codeMirror-activeline-bgColor: #afb8c133;
 --codeMirror-matchingBracket-fgColor: #1f2328;
 --codeMirror-lines-bgColor: #ffffff;
 --codeMirror-syntax-fgColor-comment: #24292f;
@@ -159,8 +159,8 @@
 --button-danger-borderColor-hover: #1f232826;
 --button-danger-borderColor-active: #1f232826;
 --button-danger-shadow-selected: inset 0px 1px 0px 0px #47170033;
-  --buttonCounter-default-bgColor-rest: #eaeef2;
-  --buttonCounter-invisible-bgColor-rest: #eaeef2;
+  --buttonCounter-default-bgColor-rest: #afb8c1;
+  --buttonCounter-invisible-bgColor-rest: #afb8c1;
 --buttonCounter-primary-bgColor-rest: #002d1133;
 --buttonCounter-outline-bgColor-rest: #0969da1a;
 --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -221,7 +221,7 @@
 --bgColor-inverse: #24292f;
 --bgColor-disabled: #f6f8fa;
 --bgColor-transparent: #ffffff00;
-  --bgColor-neutral-muted: #eaeef280;
+  --bgColor-neutral-muted: #afb8c133;
 --bgColor-neutral-emphasis: #6e7781;
 --bgColor-accent-muted: #ddf4ff;
 --bgColor-accent-emphasis: #0969da;
@@ -440,7 +440,7 @@
   --codeMirror-lineNumber-fgColor: #636c76;
   --codeMirror-cursor-fgColor: #1f2328;
   --codeMirror-selection-bgColor: #54aeff66;
-    --codeMirror-activeline-bgColor: #eaeef280;
+    --codeMirror-activeline-bgColor: #afb8c133;
   --codeMirror-matchingBracket-fgColor: #1f2328;
   --codeMirror-lines-bgColor: #ffffff;
   --codeMirror-syntax-fgColor-comment: #24292f;
@@ -576,8 +576,8 @@
   --button-danger-borderColor-hover: #1f232826;
   --button-danger-borderColor-active: #1f232826;
   --button-danger-shadow-selected: inset 0px 1px 0px 0px #47170033;
-    --buttonCounter-default-bgColor-rest: #eaeef2;
-    --buttonCounter-invisible-bgColor-rest: #eaeef2;
+    --buttonCounter-default-bgColor-rest: #afb8c1;
+    --buttonCounter-invisible-bgColor-rest: #afb8c1;
   --buttonCounter-primary-bgColor-rest: #002d1133;
   --buttonCounter-outline-bgColor-rest: #0969da1a;
   --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -638,7 +638,7 @@
   --bgColor-inverse: #24292f;
   --bgColor-disabled: #f6f8fa;
   --bgColor-transparent: #ffffff00;
-    --bgColor-neutral-muted: #eaeef280;
+    --bgColor-neutral-muted: #afb8c133;
   --bgColor-neutral-emphasis: #6e7781;
   --bgColor-accent-muted: #ddf4ff;
   --bgColor-accent-emphasis: #0969da;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css	2023-09-26 08:31:31.320399389 +0000
@@ -23,7 +23,7 @@
 --codeMirror-lineNumber-fgColor: #636c76;
 --codeMirror-cursor-fgColor: #1f2328;
 --codeMirror-selection-bgColor: #54aeff66;
-  --codeMirror-activeline-bgColor: #eaeef280;
+  --codeMirror-activeline-bgColor: #afb8c133;
 --codeMirror-matchingBracket-fgColor: #1f2328;
 --codeMirror-lines-bgColor: #ffffff;
 --codeMirror-syntax-fgColor-comment: #24292f;
@@ -159,8 +159,8 @@
 --button-danger-borderColor-hover: #1f232826;
 --button-danger-borderColor-active: #1f232826;
 --button-danger-shadow-selected: inset 0px 1px 0px 0px #4c001433;
-  --buttonCounter-default-bgColor-rest: #eaeef2;
-  --buttonCounter-invisible-bgColor-rest: #eaeef2;
+  --buttonCounter-default-bgColor-rest: #afb8c1;
+  --buttonCounter-invisible-bgColor-rest: #afb8c1;
 --buttonCounter-primary-bgColor-rest: #002d1133;
 --buttonCounter-outline-bgColor-rest: #0969da1a;
 --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -221,7 +221,7 @@
 --bgColor-inverse: #24292f;
 --bgColor-disabled: #f6f8fa;
 --bgColor-transparent: #ffffff00;
-  --bgColor-neutral-muted: #eaeef280;
+  --bgColor-neutral-muted: #afb8c133;
 --bgColor-neutral-emphasis: #6e7781;
 --bgColor-accent-muted: #ddf4ff;
 --bgColor-accent-emphasis: #0969da;
@@ -440,7 +440,7 @@
   --codeMirror-lineNumber-fgColor: #636c76;
   --codeMirror-cursor-fgColor: #1f2328;
   --codeMirror-selection-bgColor: #54aeff66;
-    --codeMirror-activeline-bgColor: #eaeef280;
+    --codeMirror-activeline-bgColor: #afb8c133;
   --codeMirror-matchingBracket-fgColor: #1f2328;
   --codeMirror-lines-bgColor: #ffffff;
   --codeMirror-syntax-fgColor-comment: #24292f;
@@ -576,8 +576,8 @@
   --button-danger-borderColor-hover: #1f232826;
   --button-danger-borderColor-active: #1f232826;
   --button-danger-shadow-selected: inset 0px 1px 0px 0px #4c001433;
-    --buttonCounter-default-bgColor-rest: #eaeef2;
-    --buttonCounter-invisible-bgColor-rest: #eaeef2;
+    --buttonCounter-default-bgColor-rest: #afb8c1;
+    --buttonCounter-invisible-bgColor-rest: #afb8c1;
   --buttonCounter-primary-bgColor-rest: #002d1133;
   --buttonCounter-outline-bgColor-rest: #0969da1a;
   --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -638,7 +638,7 @@
   --bgColor-inverse: #24292f;
   --bgColor-disabled: #f6f8fa;
   --bgColor-transparent: #ffffff00;
-    --bgColor-neutral-muted: #eaeef280;
+    --bgColor-neutral-muted: #afb8c133;
   --bgColor-neutral-emphasis: #6e7781;
   --bgColor-accent-muted: #ddf4ff;
   --bgColor-accent-emphasis: #0969da;

/css/functional/themes/light.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light.css	2023-09-26 08:31:30.520395028 +0000
@@ -23,7 +23,7 @@
 --codeMirror-lineNumber-fgColor: #636c76;
 --codeMirror-cursor-fgColor: #1f2328;
 --codeMirror-selection-bgColor: #54aeff66;
-  --codeMirror-activeline-bgColor: #eaeef280;
+  --codeMirror-activeline-bgColor: #afb8c133;
 --codeMirror-matchingBracket-fgColor: #1f2328;
 --codeMirror-lines-bgColor: #ffffff;
 --codeMirror-syntax-fgColor-comment: #24292f;
@@ -159,8 +159,8 @@
 --button-danger-borderColor-hover: #1f232826;
 --button-danger-borderColor-active: #1f232826;
 --button-danger-shadow-selected: inset 0px 1px 0px 0px #4c001433;
-  --buttonCounter-default-bgColor-rest: #eaeef2;
-  --buttonCounter-invisible-bgColor-rest: #eaeef2;
+  --buttonCounter-default-bgColor-rest: #afb8c1;
+  --buttonCounter-invisible-bgColor-rest: #afb8c1;
 --buttonCounter-primary-bgColor-rest: #002d1133;
 --buttonCounter-outline-bgColor-rest: #0969da1a;
 --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -221,7 +221,7 @@
 --bgColor-inverse: #24292f;
 --bgColor-disabled: #f6f8fa;
 --bgColor-transparent: #ffffff00;
-  --bgColor-neutral-muted: #eaeef280;
+  --bgColor-neutral-muted: #afb8c133;
 --bgColor-neutral-emphasis: #6e7781;
 --bgColor-accent-muted: #ddf4ff;
 --bgColor-accent-emphasis: #0969da;
@@ -440,7 +440,7 @@
   --codeMirror-lineNumber-fgColor: #636c76;
   --codeMirror-cursor-fgColor: #1f2328;
   --codeMirror-selection-bgColor: #54aeff66;
-    --codeMirror-activeline-bgColor: #eaeef280;
+    --codeMirror-activeline-bgColor: #afb8c133;
   --codeMirror-matchingBracket-fgColor: #1f2328;
   --codeMirror-lines-bgColor: #ffffff;
   --codeMirror-syntax-fgColor-comment: #24292f;
@@ -576,8 +576,8 @@
   --button-danger-borderColor-hover: #1f232826;
   --button-danger-borderColor-active: #1f232826;
   --button-danger-shadow-selected: inset 0px 1px 0px 0px #4c001433;
-    --buttonCounter-default-bgColor-rest: #eaeef2;
-    --buttonCounter-invisible-bgColor-rest: #eaeef2;
+    --buttonCounter-default-bgColor-rest: #afb8c1;
+    --buttonCounter-invisible-bgColor-rest: #afb8c1;
   --buttonCounter-primary-bgColor-rest: #002d1133;
   --buttonCounter-outline-bgColor-rest: #0969da1a;
   --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -638,7 +638,7 @@
   --bgColor-inverse: #24292f;
   --bgColor-disabled: #f6f8fa;
   --bgColor-transparent: #ffffff00;
-    --bgColor-neutral-muted: #eaeef280;
+    --bgColor-neutral-muted: #afb8c133;
   --bgColor-neutral-emphasis: #6e7781;
   --bgColor-accent-muted: #ddf4ff;
   --bgColor-accent-emphasis: #0969da;

@github-actions github-actions bot temporarily deployed to storybook-preview September 26, 2023 08:33 Inactive
@lukasoppermann lukasoppermann added the update snapshots Update visual regression test snapshots label Sep 26, 2023
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Sep 26, 2023
@lukasoppermann lukasoppermann merged commit 04a316c into main Sep 26, 2023
@lukasoppermann lukasoppermann deleted the bgColor-neutral-muted branch September 26, 2023 08:56
@primer primer bot mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasahlin tobiasahlin Awaiting requested review from tobiasahlin tobiasahlin is a code owner automatically assigned from primer/css-reviewers

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann