-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm most scales from output #851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e5395b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Variables changedNo variables changed |
Design Token Diff
|
lukasoppermann
temporarily deployed
to
github-pages
April 1, 2024 08:19
— with
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
rm-scales-from-output
branch
from
April 1, 2024 08:21
3358c2d
to
a30dc30
Compare
lukasoppermann
temporarily deployed
to
github-pages
April 1, 2024 08:23
— with
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
April 2, 2024 08:58
— with
GitHub Actions
Inactive
@langermank I updated storybook to use base colors and removed the color-scale colors. Is there any reason we can't do this? |
lukasoppermann
temporarily deployed
to
github-pages
April 2, 2024 12:52
— with
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
rm-scales-from-output
branch
from
April 2, 2024 12:54
a203a76
to
7065006
Compare
lukasoppermann
force-pushed
the
rm-scales-from-output
branch
from
April 2, 2024 12:55
7065006
to
0e5395b
Compare
lukasoppermann
temporarily deployed
to
github-pages
April 2, 2024 12:57
— with
GitHub Actions
Inactive
langermank
approved these changes
Apr 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
color-scale-
colors from the output but keeps it ininternalCss
.Problem
We have some overwrites to change the scale colors, that are still present in the output.
However, if we want it to be present in the
internalCss
we need to add it somewhere.I am wondering if we can remove just remove the
scale-color
colors frominternalCss
as well, since we also have thebase-color
tokens ininternalCss
. @langermank ?I think we should be able to jsut rip out
color-scale
entirely if we don't need them in the output. They just duplicated the base scales without the need to include base scales.Those are still available in
internalCss
: