Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the fgColor-done for dark mode to pass contrast #889

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix the fgColor-done for dark mode to pass contrast #889

merged 1 commit into from
Apr 16, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

This fixes the last failing contrast check for dark mode

@lukasoppermann lukasoppermann requested review from a team as code owners April 16, 2024 12:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c8d9f50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

Variables changed 
No variables changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

Design Token Contrast Check

light: ✅ all checks passed

Show results table for theme: light
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default ✅ 15.79:1 4.5:1
fgColor-muted vs. bgColor-default ✅ 5.33:1 4.5:1
fgColor-default vs. bgColor-muted ✅ 14.83:1 4.5:1
fgColor-muted vs. bgColor-muted ✅ 5.01:1 4.5:1
fgColor-default vs. bgColor-inset ✅ 14.83:1 4.5:1
fgColor-muted vs. bgColor-inset ✅ 5.01:1 4.5:1
fgColor-default vs. bgColor-accent-muted ✅ 13.88:1 4.5:1
fgColor-default vs. bgColor-success-muted ✅ 14.19:1 4.5:1
fgColor-default vs. bgColor-open-muted ✅ 14.19:1 4.5:1
fgColor-default vs. bgColor-danger-muted ✅ 13.77:1 4.5:1
fgColor-default vs. bgColor-closed-muted ✅ 13.77:1 4.5:1
fgColor-default vs. bgColor-attention-muted ✅ 14.65:1 4.5:1
fgColor-default vs. bgColor-severe-muted ✅ 14.26:1 4.5:1
fgColor-default vs. bgColor-done-muted ✅ 14.21:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted ✅ 14.24:1 4.5:1
fgColor-accent vs. bgColor-default ✅ 5.19:1 4.5:1
fgColor-accent vs. bgColor-muted ✅ 4.87:1 4.5:1
fgColor-accent vs. bgColor-inset ✅ 4.87:1 4.5:1
fgColor-success vs. bgColor-default ✅ 5.07:1 4.5:1
fgColor-success vs. bgColor-muted ✅ 4.77:1 4.5:1
fgColor-success vs. bgColor-inset ✅ 4.77:1 4.5:1
fgColor-open vs. bgColor-default ✅ 5.07:1 4.5:1
fgColor-open vs. bgColor-muted ✅ 4.77:1 4.5:1
fgColor-open vs. bgColor-inset ✅ 4.77:1 4.5:1
fgColor-danger vs. bgColor-default ✅ 5.24:1 4.5:1
fgColor-danger vs. bgColor-muted ✅ 4.92:1 4.5:1
fgColor-danger vs. bgColor-inset ✅ 4.92:1 4.5:1
fgColor-closed vs. bgColor-default ✅ 5.24:1 4.5:1
fgColor-closed vs. bgColor-muted ✅ 4.92:1 4.5:1
fgColor-closed vs. bgColor-inset ✅ 4.92:1 4.5:1
fgColor-attention vs. bgColor-default ✅ 4.86:1 4.5:1
fgColor-attention vs. bgColor-muted ✅ 4.57:1 4.5:1
fgColor-attention vs. bgColor-inset ✅ 4.57:1 4.5:1
fgColor-severe vs. bgColor-default ✅ 5.03:1 4.5:1
fgColor-severe vs. bgColor-muted ✅ 4.72:1 4.5:1
fgColor-severe vs. bgColor-inset ✅ 4.72:1 4.5:1
fgColor-done vs. bgColor-default ✅ 5.04:1 4.5:1
fgColor-done vs. bgColor-muted ✅ 4.73:1 4.5:1
fgColor-done vs. bgColor-inset ✅ 4.73:1 4.5:1
fgColor-sponsors vs. bgColor-default ✅ 5.04:1 4.5:1
fgColor-sponsors vs. bgColor-muted ✅ 4.73:1 4.5:1
fgColor-sponsors vs. bgColor-inset ✅ 4.73:1 4.5:1
fgColor-accent vs. bgColor-accent-muted ✅ 4.56:1 4.5:1
fgColor-success vs. bgColor-success-muted ✅ 4.56:1 4.5:1
fgColor-open vs. bgColor-open-muted ✅ 4.56:1 4.5:1
fgColor-danger vs. bgColor-danger-muted ✅ 4.57:1 4.5:1
fgColor-closed vs. bgColor-closed-muted ✅ 4.57:1 4.5:1
fgColor-attention vs. bgColor-attention-muted ✅ 4.51:1 4.5:1
fgColor-severe vs. bgColor-severe-muted ✅ 4.54:1 4.5:1
fgColor-done vs. bgColor-done-muted ✅ 4.53:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted ✅ 4.55:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis ✅ 4.54:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis ✅ 5.19:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis ✅ 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis ✅ 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis ✅ 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis ✅ 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis ✅ 4.86:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis ✅ 5.03:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis ✅ 5.04:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis ✅ 5.04:1 4.5:1
control-borderColor-emphasis vs. bgColor-default ✅ 3.27:1 3:1
control-borderColor-emphasis vs. bgColor-muted ✅ 3.08:1 3:1

dark: ✅ all checks passed

Show results table for theme: dark
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default ✅ 16.01:1 4.5:1
fgColor-muted vs. bgColor-default ✅ 5.62:1 4.5:1
fgColor-default vs. bgColor-muted ✅ 14.63:1 4.5:1
fgColor-muted vs. bgColor-muted ✅ 5.13:1 4.5:1
fgColor-default vs. bgColor-inset ✅ 17.37:1 4.5:1
fgColor-muted vs. bgColor-inset ✅ 6.1:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-default ✅ 14.34:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-muted ✅ 12.91:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-default ✅ 13.44:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-muted ✅ 12:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-default ✅ 14.28:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-muted ✅ 12.85:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-default ✅ 14.49:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-muted ✅ 13.09:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-default ✅ 13.65:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-muted ✅ 12.34:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-default ✅ 13.4:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-muted ✅ 12.08:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-default ✅ 14.45:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-muted ✅ 13.03:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-default ✅ 13.11:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-muted ✅ 11.71:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-default ✅ 14.4:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-muted ✅ 12.98:1 4.5:1
fgColor-accent vs. bgColor-default ✅ 6.1:1 4.5:1
fgColor-accent vs. bgColor-muted ✅ 5.58:1 4.5:1
fgColor-accent vs. bgColor-inset ✅ 6.62:1 4.5:1
fgColor-success vs. bgColor-default ✅ 7.44:1 4.5:1
fgColor-success vs. bgColor-muted ✅ 6.8:1 4.5:1
fgColor-success vs. bgColor-inset ✅ 8.08:1 4.5:1
fgColor-open vs. bgColor-default ✅ 7.44:1 4.5:1
fgColor-open vs. bgColor-muted ✅ 6.8:1 4.5:1
fgColor-open vs. bgColor-inset ✅ 8.08:1 4.5:1
fgColor-danger vs. bgColor-default ✅ 5.64:1 4.5:1
fgColor-danger vs. bgColor-muted ✅ 5.16:1 4.5:1
fgColor-danger vs. bgColor-inset ✅ 6.12:1 4.5:1
fgColor-closed vs. bgColor-default ✅ 5.64:1 4.5:1
fgColor-closed vs. bgColor-muted ✅ 5.16:1 4.5:1
fgColor-closed vs. bgColor-inset ✅ 6.12:1 4.5:1
fgColor-attention vs. bgColor-default ✅ 7.49:1 4.5:1
fgColor-attention vs. bgColor-muted ✅ 6.85:1 4.5:1
fgColor-attention vs. bgColor-inset ✅ 8.13:1 4.5:1
fgColor-severe vs. bgColor-default ✅ 5.61:1 4.5:1
fgColor-severe vs. bgColor-muted ✅ 5.13:1 4.5:1
fgColor-severe vs. bgColor-inset ✅ 6.09:1 4.5:1
fgColor-done vs. bgColor-default ✅ 6.32:1 4.5:1
fgColor-done vs. bgColor-muted ✅ 5.78:1 4.5:1
fgColor-done vs. bgColor-inset ✅ 6.86:1 4.5:1
fgColor-sponsors vs. bgColor-default ✅ 5.62:1 4.5:1
fgColor-sponsors vs. bgColor-muted ✅ 5.14:1 4.5:1
fgColor-sponsors vs. bgColor-inset ✅ 6.1:1 4.5:1
fgColor-accent vs. bgColor-accent-muted on bgColor-default ✅ 5.46:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-default ✅ 6.25:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-muted ✅ 5.58:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-default ✅ 6.64:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-muted ✅ 5.97:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-default ✅ 5.1:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-muted ✅ 4.61:1 4.5:1
fgColor-closed vs. bgColor-closed-muted on bgColor-default ✅ 4.81:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-default ✅ 6.27:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-muted ✅ 5.65:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-default ✅ 5.06:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-muted ✅ 4.57:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-default ✅ 5.18:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-muted ✅ 4.62:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-default ✅ 5.06:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-muted ✅ 4.56:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis ✅ 4.59:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis ✅ 4.64:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis ✅ 4.65:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis ✅ 4.57:1 4.5:1
control-borderColor-emphasis vs. bgColor-default ✅ 3.66:1 3:1
control-borderColor-emphasis vs. bgColor-muted ✅ 3.35:1 3:1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

Design Token Diff

/css/functional/themes/dark-colorblind.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-colorblind.css	2024-04-16 13:00:22.608668279 +0000
@@ -418,8 +418,8 @@
 --fgColor-danger: #db6d28;
 --fgColor-open: #f0883e;
 --fgColor-closed: #8b949e;
-  --fgColor-done: #a371f7;
-  --fgColor-upsell: #a371f7;
+  --fgColor-done: #ab7df8;
+  --fgColor-upsell: #ab7df8;
 --fgColor-sponsors: #db61a2;
 --bgColor-default: #0d1117;
 --bgColor-muted: #161b22;
@@ -446,9 +446,9 @@
 --bgColor-open-emphasis: #bd561d;
 --bgColor-closed-muted: #6e768166;
 --bgColor-closed-emphasis: #6e7681;
-  --bgColor-done-muted: #a371f726;
+  --bgColor-done-muted: #ab7df826;
 --bgColor-done-emphasis: #8957e5;
-  --bgColor-upsell-muted: #a371f726;
+  --bgColor-upsell-muted: #ab7df826;
 --bgColor-upsell-emphasis: #8957e5;
 --bgColor-sponsors-muted: #db61a21a;
 --bgColor-sponsors-emphasis: #bf4b8a;
@@ -473,9 +473,9 @@
 --borderColor-open-emphasis: #db6d28;
 --borderColor-closed-muted: #6e768166;
 --borderColor-closed-emphasis: #6e7681;
-  --borderColor-done-muted: #a371f766;
+  --borderColor-done-muted: #ab7df866;
 --borderColor-done-emphasis: #8957e5;
-  --borderColor-upsell-muted: #a371f766;
+  --borderColor-upsell-muted: #ab7df866;
 --borderColor-upsell-emphasis: #8957e5;
 --borderColor-sponsors-muted: #db61a266;
 --borderColor-sponsors-emphasis: #bf4b8a;
@@ -492,7 +492,7 @@
 --color-ansi-yellow-bright: #e3b341;
 --color-ansi-blue: #58a6ff;
 --color-ansi-blue-bright: #79c0ff;
-  --color-ansi-magenta: #bc8cff;
+  --color-ansi-magenta: #be8fff;
 --color-ansi-magenta-bright: #d2a8ff;
 --color-ansi-cyan: #39c5cf;
 --color-ansi-cyan-bright: #56d4dd;
@@ -956,8 +956,8 @@
   --fgColor-danger: #db6d28;
   --fgColor-open: #f0883e;
   --fgColor-closed: #8b949e;
-    --fgColor-done: #a371f7;
-    --fgColor-upsell: #a371f7;
+    --fgColor-done: #ab7df8;
+    --fgColor-upsell: #ab7df8;
   --fgColor-sponsors: #db61a2;
   --bgColor-default: #0d1117;
   --bgColor-muted: #161b22;
@@ -984,9 +984,9 @@
   --bgColor-open-emphasis: #bd561d;
   --bgColor-closed-muted: #6e768166;
   --bgColor-closed-emphasis: #6e7681;
-    --bgColor-done-muted: #a371f726;
+    --bgColor-done-muted: #ab7df826;
   --bgColor-done-emphasis: #8957e5;
-    --bgColor-upsell-muted: #a371f726;
+    --bgColor-upsell-muted: #ab7df826;
   --bgColor-upsell-emphasis: #8957e5;
   --bgColor-sponsors-muted: #db61a21a;
   --bgColor-sponsors-emphasis: #bf4b8a;
@@ -1011,9 +1011,9 @@
   --borderColor-open-emphasis: #db6d28;
   --borderColor-closed-muted: #6e768166;
   --borderColor-closed-emphasis: #6e7681;
-    --borderColor-done-muted: #a371f766;
+    --borderColor-done-muted: #ab7df866;
   --borderColor-done-emphasis: #8957e5;
-    --borderColor-upsell-muted: #a371f766;
+    --borderColor-upsell-muted: #ab7df866;
   --borderColor-upsell-emphasis: #8957e5;
   --borderColor-sponsors-muted: #db61a266;
   --borderColor-sponsors-emphasis: #bf4b8a;
@@ -1030,7 +1030,7 @@
   --color-ansi-yellow-bright: #e3b341;
   --color-ansi-blue: #58a6ff;
   --color-ansi-blue-bright: #79c0ff;
-    --color-ansi-magenta: #bc8cff;
+    --color-ansi-magenta: #be8fff;
   --color-ansi-magenta-bright: #d2a8ff;
   --color-ansi-cyan: #39c5cf;
   --color-ansi-cyan-bright: #56d4dd;

/css/functional/themes/dark-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-tritanopia.css	2024-04-16 13:00:22.004659891 +0000
@@ -418,8 +418,8 @@
 --fgColor-danger: #f85149;
 --fgColor-open: #f85149;
 --fgColor-closed: #6e7681;
-  --fgColor-done: #a371f7;
-  --fgColor-upsell: #a371f7;
+  --fgColor-done: #ab7df8;
+  --fgColor-upsell: #ab7df8;
 --fgColor-sponsors: #db61a2;
 --bgColor-default: #0d1117;
 --bgColor-muted: #161b22;
@@ -446,9 +446,9 @@
 --bgColor-open-emphasis: #da3633;
 --bgColor-closed-muted: #6e768126;
 --bgColor-closed-emphasis: #484f58;
-  --bgColor-done-muted: #a371f726;
+  --bgColor-done-muted: #ab7df826;
 --bgColor-done-emphasis: #8957e5;
-  --bgColor-upsell-muted: #a371f726;
+  --bgColor-upsell-muted: #ab7df826;
 --bgColor-upsell-emphasis: #8957e5;
 --bgColor-sponsors-muted: #db61a21a;
 --bgColor-sponsors-emphasis: #bf4b8a;
@@ -473,9 +473,9 @@
 --borderColor-open-emphasis: #da3633;
 --borderColor-closed-muted: #6e768166;
 --borderColor-closed-emphasis: #484f58;
-  --borderColor-done-muted: #a371f766;
+  --borderColor-done-muted: #ab7df866;
 --borderColor-done-emphasis: #8957e5;
-  --borderColor-upsell-muted: #a371f766;
+  --borderColor-upsell-muted: #ab7df866;
 --borderColor-upsell-emphasis: #8957e5;
 --borderColor-sponsors-muted: #db61a266;
 --borderColor-sponsors-emphasis: #bf4b8a;
@@ -492,7 +492,7 @@
 --color-ansi-yellow-bright: #e3b341;
 --color-ansi-blue: #58a6ff;
 --color-ansi-blue-bright: #79c0ff;
-  --color-ansi-magenta: #bc8cff;
+  --color-ansi-magenta: #be8fff;
 --color-ansi-magenta-bright: #d2a8ff;
 --color-ansi-cyan: #39c5cf;
 --color-ansi-cyan-bright: #56d4dd;
@@ -956,8 +956,8 @@
   --fgColor-danger: #f85149;
   --fgColor-open: #f85149;
   --fgColor-closed: #6e7681;
-    --fgColor-done: #a371f7;
-    --fgColor-upsell: #a371f7;
+    --fgColor-done: #ab7df8;
+    --fgColor-upsell: #ab7df8;
   --fgColor-sponsors: #db61a2;
   --bgColor-default: #0d1117;
   --bgColor-muted: #161b22;
@@ -984,9 +984,9 @@
   --bgColor-open-emphasis: #da3633;
   --bgColor-closed-muted: #6e768126;
   --bgColor-closed-emphasis: #484f58;
-    --bgColor-done-muted: #a371f726;
+    --bgColor-done-muted: #ab7df826;
   --bgColor-done-emphasis: #8957e5;
-    --bgColor-upsell-muted: #a371f726;
+    --bgColor-upsell-muted: #ab7df826;
   --bgColor-upsell-emphasis: #8957e5;
   --bgColor-sponsors-muted: #db61a21a;
   --bgColor-sponsors-emphasis: #bf4b8a;
@@ -1011,9 +1011,9 @@
   --borderColor-open-emphasis: #da3633;
   --borderColor-closed-muted: #6e768166;
   --borderColor-closed-emphasis: #484f58;
-    --borderColor-done-muted: #a371f766;
+    --borderColor-done-muted: #ab7df866;
   --borderColor-done-emphasis: #8957e5;
-    --borderColor-upsell-muted: #a371f766;
+    --borderColor-upsell-muted: #ab7df866;
   --borderColor-upsell-emphasis: #8957e5;
   --borderColor-sponsors-muted: #db61a266;
   --borderColor-sponsors-emphasis: #bf4b8a;
@@ -1030,7 +1030,7 @@
   --color-ansi-yellow-bright: #e3b341;
   --color-ansi-blue: #58a6ff;
   --color-ansi-blue-bright: #79c0ff;
-    --color-ansi-magenta: #bc8cff;
+    --color-ansi-magenta: #be8fff;
   --color-ansi-magenta-bright: #d2a8ff;
   --color-ansi-cyan: #39c5cf;
   --color-ansi-cyan-bright: #56d4dd;

/css/functional/themes/dark.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark.css	2024-04-16 13:00:20.664640994 +0000
@@ -418,8 +418,8 @@
 --fgColor-danger: #f85149;
 --fgColor-open: #3fb950;
 --fgColor-closed: #f85149;
-  --fgColor-done: #a371f7;
-  --fgColor-upsell: #a371f7;
+  --fgColor-done: #ab7df8;
+  --fgColor-upsell: #ab7df8;
 --fgColor-sponsors: #db61a2;
 --bgColor-default: #0d1117;
 --bgColor-muted: #161b22;
@@ -446,9 +446,9 @@
 --bgColor-open-emphasis: #238636;
 --bgColor-closed-muted: #f8514926;
 --bgColor-closed-emphasis: #da3633;
-  --bgColor-done-muted: #a371f726;
+  --bgColor-done-muted: #ab7df826;
 --bgColor-done-emphasis: #8957e5;
-  --bgColor-upsell-muted: #a371f726;
+  --bgColor-upsell-muted: #ab7df826;
 --bgColor-upsell-emphasis: #8957e5;
 --bgColor-sponsors-muted: #db61a21a;
 --bgColor-sponsors-emphasis: #bf4b8a;
@@ -473,9 +473,9 @@
 --borderColor-open-emphasis: #238636;
 --borderColor-closed-muted: #f8514966;
 --borderColor-closed-emphasis: #da3633;
-  --borderColor-done-muted: #a371f766;
+  --borderColor-done-muted: #ab7df866;
 --borderColor-done-emphasis: #8957e5;
-  --borderColor-upsell-muted: #a371f766;
+  --borderColor-upsell-muted: #ab7df866;
 --borderColor-upsell-emphasis: #8957e5;
 --borderColor-sponsors-muted: #db61a266;
 --borderColor-sponsors-emphasis: #bf4b8a;
@@ -492,7 +492,7 @@
 --color-ansi-yellow-bright: #e3b341;
 --color-ansi-blue: #58a6ff;
 --color-ansi-blue-bright: #79c0ff;
-  --color-ansi-magenta: #bc8cff;
+  --color-ansi-magenta: #be8fff;
 --color-ansi-magenta-bright: #d2a8ff;
 --color-ansi-cyan: #39c5cf;
 --color-ansi-cyan-bright: #56d4dd;
@@ -956,8 +956,8 @@
   --fgColor-danger: #f85149;
   --fgColor-open: #3fb950;
   --fgColor-closed: #f85149;
-    --fgColor-done: #a371f7;
-    --fgColor-upsell: #a371f7;
+    --fgColor-done: #ab7df8;
+    --fgColor-upsell: #ab7df8;
   --fgColor-sponsors: #db61a2;
   --bgColor-default: #0d1117;
   --bgColor-muted: #161b22;
@@ -984,9 +984,9 @@
   --bgColor-open-emphasis: #238636;
   --bgColor-closed-muted: #f8514926;
   --bgColor-closed-emphasis: #da3633;
-    --bgColor-done-muted: #a371f726;
+    --bgColor-done-muted: #ab7df826;
   --bgColor-done-emphasis: #8957e5;
-    --bgColor-upsell-muted: #a371f726;
+    --bgColor-upsell-muted: #ab7df826;
   --bgColor-upsell-emphasis: #8957e5;
   --bgColor-sponsors-muted: #db61a21a;
   --bgColor-sponsors-emphasis: #bf4b8a;
@@ -1011,9 +1011,9 @@
   --borderColor-open-emphasis: #238636;
   --borderColor-closed-muted: #f8514966;
   --borderColor-closed-emphasis: #da3633;
-    --borderColor-done-muted: #a371f766;
+    --borderColor-done-muted: #ab7df866;
   --borderColor-done-emphasis: #8957e5;
-    --borderColor-upsell-muted: #a371f766;
+    --borderColor-upsell-muted: #ab7df866;
   --borderColor-upsell-emphasis: #8957e5;
   --borderColor-sponsors-muted: #db61a266;
   --borderColor-sponsors-emphasis: #bf4b8a;
@@ -1030,7 +1030,7 @@
   --color-ansi-yellow-bright: #e3b341;
   --color-ansi-blue: #58a6ff;
   --color-ansi-blue-bright: #79c0ff;
-    --color-ansi-magenta: #bc8cff;
+    --color-ansi-magenta: #be8fff;
   --color-ansi-magenta-bright: #d2a8ff;
   --color-ansi-cyan: #39c5cf;
   --color-ansi-cyan-bright: #56d4dd;

@lukasoppermann lukasoppermann merged commit ef6a6c3 into main Apr 16, 2024
27 checks passed
@lukasoppermann lukasoppermann deleted the fix-fg-done-dark branch April 16, 2024 13:14
@primer primer bot mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann