Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add borderColor-translucent #969

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Add borderColor-translucent #969

merged 6 commits into from
Jun 17, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jun 14, 2024

Adds a generic border token for things like Avatar or language dots.

border on some dots

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: f2f47d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 14, 2024

Design Token Contrast Check

light: ✅ all checks passed

Show results table for theme: light
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default 15.79:1 4.5:1
fgColor-muted vs. bgColor-default 5.33:1 4.5:1
fgColor-default vs. bgColor-muted 14.83:1 4.5:1
fgColor-muted vs. bgColor-muted 5.01:1 4.5:1
fgColor-default vs. bgColor-inset 14.83:1 4.5:1
fgColor-muted vs. bgColor-inset 5.01:1 4.5:1
control-fgColor-rest vs. bgColor-default 14.65:1 4.5:1
control-fgColor-rest vs. bgColor-muted 13.76:1 4.5:1
control-fgColor-rest vs. bgColor-inset 13.76:1 4.5:1
control-fgColor-rest vs. control-bgColor-rest 13.76:1 4.5:1
control-fgColor-placeholder vs. control-bgColor-rest 4.58:1 4.5:1
control-fgColor-rest vs. control-bgColor-active 12.22:1 4.5:1
control-fgColor-rest vs. control-bgColor-selected 13.76:1 4.5:1
fgColor-default vs. bgColor-accent-muted 13.88:1 4.5:1
fgColor-default vs. bgColor-success-muted 14.19:1 4.5:1
fgColor-default vs. bgColor-open-muted 14.19:1 4.5:1
fgColor-default vs. bgColor-danger-muted 13.77:1 4.5:1
fgColor-default vs. bgColor-closed-muted 13.77:1 4.5:1
fgColor-default vs. bgColor-attention-muted 14.65:1 4.5:1
fgColor-default vs. bgColor-severe-muted 14.26:1 4.5:1
fgColor-default vs. bgColor-done-muted 14.21:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted 14.24:1 4.5:1
fgColor-accent vs. bgColor-default 5.19:1 4.5:1
fgColor-accent vs. bgColor-muted 4.87:1 4.5:1
fgColor-accent vs. bgColor-inset 4.87:1 4.5:1
fgColor-success vs. bgColor-default 5.07:1 4.5:1
fgColor-success vs. bgColor-muted 4.77:1 4.5:1
fgColor-success vs. bgColor-inset 4.77:1 4.5:1
fgColor-open vs. bgColor-default 5.07:1 4.5:1
fgColor-open vs. bgColor-muted 4.77:1 4.5:1
fgColor-open vs. bgColor-inset 4.77:1 4.5:1
fgColor-danger vs. bgColor-default 5.24:1 4.5:1
fgColor-danger vs. bgColor-muted 4.92:1 4.5:1
fgColor-danger vs. bgColor-inset 4.92:1 4.5:1
fgColor-closed vs. bgColor-default 5.24:1 4.5:1
fgColor-closed vs. bgColor-muted 4.92:1 4.5:1
fgColor-closed vs. bgColor-inset 4.92:1 4.5:1
fgColor-attention vs. bgColor-default 4.86:1 4.5:1
fgColor-attention vs. bgColor-muted 4.57:1 4.5:1
fgColor-attention vs. bgColor-inset 4.57:1 4.5:1
fgColor-severe vs. bgColor-default 5.03:1 4.5:1
fgColor-severe vs. bgColor-muted 4.72:1 4.5:1
fgColor-severe vs. bgColor-inset 4.72:1 4.5:1
fgColor-done vs. bgColor-default 5.04:1 4.5:1
fgColor-done vs. bgColor-muted 4.73:1 4.5:1
fgColor-done vs. bgColor-inset 4.73:1 4.5:1
fgColor-sponsors vs. bgColor-default 5.04:1 4.5:1
fgColor-sponsors vs. bgColor-muted 4.73:1 4.5:1
fgColor-sponsors vs. bgColor-inset 4.73:1 4.5:1
fgColor-accent vs. bgColor-accent-muted 4.56:1 4.5:1
fgColor-success vs. bgColor-success-muted 4.56:1 4.5:1
fgColor-open vs. bgColor-open-muted 4.56:1 4.5:1
fgColor-danger vs. bgColor-danger-muted 4.57:1 4.5:1
fgColor-closed vs. bgColor-closed-muted 4.57:1 4.5:1
fgColor-attention vs. bgColor-attention-muted 4.51:1 4.5:1
fgColor-severe vs. bgColor-severe-muted 4.54:1 4.5:1
fgColor-done vs. bgColor-done-muted 4.53:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted 4.55:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis 4.54:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis 5.19:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis 4.86:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis 5.03:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis 5.04:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis 5.04:1 4.5:1
control-borderColor-emphasis vs. bgColor-default 3.27:1 3:1
control-borderColor-emphasis vs. bgColor-muted 3.08:1 3:1

dark: ✅ all checks passed

Show results table for theme: dark
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default 16.01:1 4.5:1
fgColor-muted vs. bgColor-default 6.31:1 4.5:1
fgColor-default vs. bgColor-muted 14.63:1 4.5:1
fgColor-muted vs. bgColor-muted 5.76:1 4.5:1
fgColor-default vs. bgColor-inset 17.37:1 4.5:1
fgColor-muted vs. bgColor-inset 6.84:1 4.5:1
control-fgColor-rest vs. bgColor-default 12.26:1 4.5:1
control-fgColor-rest vs. bgColor-muted 11.2:1 4.5:1
control-fgColor-rest vs. bgColor-inset 13.3:1 4.5:1
control-fgColor-rest vs. control-bgColor-rest 9.86:1 4.5:1
control-fgColor-placeholder vs. control-bgColor-rest 4.58:1 4.5:1
control-fgColor-rest vs. control-bgColor-active 7.87:1 4.5:1
control-fgColor-rest vs. control-bgColor-selected 11.2:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-default 14.34:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-muted 12.91:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-default 13.44:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-muted 12:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-default 14.28:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-muted 12.85:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-default 14.49:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-muted 13.09:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-default 13.65:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-muted 12.34:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-default 13.4:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-muted 12.08:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-default 14.45:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-muted 13.03:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-default 13.11:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-muted 11.71:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-default 14.4:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-muted 12.98:1 4.5:1
fgColor-accent vs. bgColor-default 6.1:1 4.5:1
fgColor-accent vs. bgColor-muted 5.58:1 4.5:1
fgColor-accent vs. bgColor-inset 6.62:1 4.5:1
fgColor-success vs. bgColor-default 7.44:1 4.5:1
fgColor-success vs. bgColor-muted 6.8:1 4.5:1
fgColor-success vs. bgColor-inset 8.08:1 4.5:1
fgColor-open vs. bgColor-default 7.44:1 4.5:1
fgColor-open vs. bgColor-muted 6.8:1 4.5:1
fgColor-open vs. bgColor-inset 8.08:1 4.5:1
fgColor-danger vs. bgColor-default 5.64:1 4.5:1
fgColor-danger vs. bgColor-muted 5.16:1 4.5:1
fgColor-danger vs. bgColor-inset 6.12:1 4.5:1
fgColor-closed vs. bgColor-default 5.64:1 4.5:1
fgColor-closed vs. bgColor-muted 5.16:1 4.5:1
fgColor-closed vs. bgColor-inset 6.12:1 4.5:1
fgColor-attention vs. bgColor-default 7.49:1 4.5:1
fgColor-attention vs. bgColor-muted 6.85:1 4.5:1
fgColor-attention vs. bgColor-inset 8.13:1 4.5:1
fgColor-severe vs. bgColor-default 5.61:1 4.5:1
fgColor-severe vs. bgColor-muted 5.13:1 4.5:1
fgColor-severe vs. bgColor-inset 6.09:1 4.5:1
fgColor-done vs. bgColor-default 6.32:1 4.5:1
fgColor-done vs. bgColor-muted 5.78:1 4.5:1
fgColor-done vs. bgColor-inset 6.86:1 4.5:1
fgColor-sponsors vs. bgColor-default 5.62:1 4.5:1
fgColor-sponsors vs. bgColor-muted 5.14:1 4.5:1
fgColor-sponsors vs. bgColor-inset 6.1:1 4.5:1
fgColor-accent vs. bgColor-accent-muted on bgColor-default 5.46:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-default 6.25:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-muted 5.58:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-default 6.64:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-muted 5.97:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-default 5.1:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-muted 4.61:1 4.5:1
fgColor-closed vs. bgColor-closed-muted on bgColor-default 4.81:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-default 6.27:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-muted 5.65:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-default 5.06:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-muted 4.57:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-default 5.18:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-muted 4.62:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-default 5.06:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-muted 4.56:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis 4.59:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis 4.64:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis 4.65:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis 4.57:1 4.5:1
control-borderColor-emphasis vs. bgColor-default 3.66:1 3:1
control-borderColor-emphasis vs. bgColor-muted 3.35:1 3:1

Copy link
Contributor

github-actions bot commented Jun 14, 2024

Design Token Diff

/css/functional/themes/dark-colorblind.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-colorblind.css	2024-06-14 23:48:11.668700396 +0000
@@ -482,6 +482,7 @@
 --borderColor-emphasis: #484f58;
 --borderColor-disabled: #21262db3;
 --borderColor-transparent: #00000000;
+  --borderColor-translucent: #ffffff26;
 --borderColor-neutral-muted: #6e768166;
 --borderColor-neutral-emphasis: #6e7681;
 --borderColor-accent-muted: #388bfd66;
@@ -1045,6 +1046,7 @@
   --borderColor-emphasis: #484f58;
   --borderColor-disabled: #21262db3;
   --borderColor-transparent: #00000000;
+    --borderColor-translucent: #ffffff26;
   --borderColor-neutral-muted: #6e768166;
   --borderColor-neutral-emphasis: #6e7681;
   --borderColor-accent-muted: #388bfd66;

/css/functional/themes/dark-dimmed.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-dimmed.css	2024-06-14 23:48:10.280693539 +0000
@@ -482,6 +482,7 @@
 --borderColor-emphasis: #545d68;
 --borderColor-disabled: #373e47b3;
 --borderColor-transparent: #00000000;
+  --borderColor-translucent: #cdd9e526;
 --borderColor-neutral-muted: #636e7b66;
 --borderColor-neutral-emphasis: #636e7b;
 --borderColor-accent-muted: #4184e466;
@@ -1045,6 +1046,7 @@
   --borderColor-emphasis: #545d68;
   --borderColor-disabled: #373e47b3;
   --borderColor-transparent: #00000000;
+    --borderColor-translucent: #cdd9e526;
   --borderColor-neutral-muted: #636e7b66;
   --borderColor-neutral-emphasis: #636e7b;
   --borderColor-accent-muted: #4184e466;

/css/functional/themes/dark-high-contrast.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-high-contrast.css	2024-06-14 23:48:12.360703815 +0000
@@ -482,6 +482,7 @@
 --borderColor-emphasis: #7a828e;
 --borderColor-disabled: #3d424db3;
 --borderColor-transparent: #00000000;
+  --borderColor-translucent: #7a828e;
 --borderColor-neutral-muted: #9ea7b3;
 --borderColor-neutral-emphasis: #9ea7b3;
 --borderColor-accent-muted: #5cacff;
@@ -1045,6 +1046,7 @@
   --borderColor-emphasis: #7a828e;
   --borderColor-disabled: #3d424db3;
   --borderColor-transparent: #00000000;
+    --borderColor-translucent: #7a828e;
   --borderColor-neutral-muted: #9ea7b3;
   --borderColor-neutral-emphasis: #9ea7b3;
   --borderColor-accent-muted: #5cacff;

/css/functional/themes/dark-tritanopia.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark-tritanopia.css	2024-06-14 23:48:10.968696938 +0000
@@ -482,6 +482,7 @@
 --borderColor-emphasis: #484f58;
 --borderColor-disabled: #21262db3;
 --borderColor-transparent: #00000000;
+  --borderColor-translucent: #ffffff26;
 --borderColor-neutral-muted: #6e768166;
 --borderColor-neutral-emphasis: #6e7681;
 --borderColor-accent-muted: #388bfd66;
@@ -1045,6 +1046,7 @@
   --borderColor-emphasis: #484f58;
   --borderColor-disabled: #21262db3;
   --borderColor-transparent: #00000000;
+    --borderColor-translucent: #ffffff26;
   --borderColor-neutral-muted: #6e768166;
   --borderColor-neutral-emphasis: #6e7681;
   --borderColor-accent-muted: #388bfd66;

/css/functional/themes/dark.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/dark.css	2024-06-14 23:48:09.568690022 +0000
@@ -482,6 +482,7 @@
 --borderColor-emphasis: #484f58;
 --borderColor-disabled: #21262db3;
 --borderColor-transparent: #00000000;
+  --borderColor-translucent: #ffffff26;
 --borderColor-neutral-muted: #6e768166;
 --borderColor-neutral-emphasis: #6e7681;
 --borderColor-accent-muted: #388bfd66;
@@ -1045,6 +1046,7 @@
   --borderColor-emphasis: #484f58;
   --borderColor-disabled: #21262db3;
   --borderColor-transparent: #00000000;
+    --borderColor-translucent: #ffffff26;
   --borderColor-neutral-muted: #6e768166;
   --borderColor-neutral-emphasis: #6e7681;
   --borderColor-accent-muted: #388bfd66;

/css/functional/themes/light-colorblind.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-colorblind.css	2024-06-14 23:48:08.072682660 +0000
@@ -483,6 +483,7 @@
 --borderColor-emphasis: #6e7781;
 --borderColor-disabled: #eaeef2b3;
 --borderColor-transparent: #ffffff00;
+  --borderColor-translucent: #1f232826;
 --borderColor-neutral-muted: #afb8c133;
 --borderColor-neutral-emphasis: #6e7781;
 --borderColor-accent-muted: #54aeff66;
@@ -1046,6 +1047,7 @@
   --borderColor-emphasis: #6e7781;
   --borderColor-disabled: #eaeef2b3;
   --borderColor-transparent: #ffffff00;
+    --borderColor-translucent: #1f232826;
   --borderColor-neutral-muted: #afb8c133;
   --borderColor-neutral-emphasis: #6e7781;
   --borderColor-accent-muted: #54aeff66;

/css/functional/themes/light-high-contrast.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-high-contrast.css	2024-06-14 23:48:08.772686090 +0000
@@ -483,6 +483,7 @@
 --borderColor-emphasis: #66707b;
 --borderColor-disabled: #ced5dcb3;
 --borderColor-transparent: #ffffff00;
+  --borderColor-translucent: #20252c;
 --borderColor-neutral-muted: #88929d;
 --borderColor-neutral-emphasis: #66707b;
 --borderColor-accent-muted: #368cf9;
@@ -1046,6 +1047,7 @@
   --borderColor-emphasis: #66707b;
   --borderColor-disabled: #ced5dcb3;
   --borderColor-transparent: #ffffff00;
+    --borderColor-translucent: #20252c;
   --borderColor-neutral-muted: #88929d;
   --borderColor-neutral-emphasis: #66707b;
   --borderColor-accent-muted: #368cf9;

/css/functional/themes/light-tritanopia.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light-tritanopia.css	2024-06-14 23:48:07.344679167 +0000
@@ -483,6 +483,7 @@
 --borderColor-emphasis: #6e7781;
 --borderColor-disabled: #eaeef2b3;
 --borderColor-transparent: #ffffff00;
+  --borderColor-translucent: #1f232826;
 --borderColor-neutral-muted: #afb8c133;
 --borderColor-neutral-emphasis: #6e7781;
 --borderColor-accent-muted: #54aeff66;
@@ -1046,6 +1047,7 @@
   --borderColor-emphasis: #6e7781;
   --borderColor-disabled: #eaeef2b3;
   --borderColor-transparent: #ffffff00;
+    --borderColor-translucent: #1f232826;
   --borderColor-neutral-muted: #afb8c133;
   --borderColor-neutral-emphasis: #6e7781;
   --borderColor-accent-muted: #54aeff66;

/css/functional/themes/light.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/themes/light.css	2024-06-14 23:48:06.380674542 +0000
@@ -483,6 +483,7 @@
 --borderColor-emphasis: #6e7781;
 --borderColor-disabled: #eaeef2b3;
 --borderColor-transparent: #ffffff00;
+  --borderColor-translucent: #1f232826;
 --borderColor-neutral-muted: #afb8c133;
 --borderColor-neutral-emphasis: #6e7781;
 --borderColor-accent-muted: #54aeff66;
@@ -1046,6 +1047,7 @@
   --borderColor-emphasis: #6e7781;
   --borderColor-disabled: #eaeef2b3;
   --borderColor-transparent: #ffffff00;
+    --borderColor-translucent: #1f232826;
   --borderColor-neutral-muted: #afb8c133;
   --borderColor-neutral-emphasis: #6e7781;
   --borderColor-accent-muted: #54aeff66;

@langermank langermank added the update snapshots Update visual regression test snapshots label Jun 14, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 14, 2024 23:14 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 14, 2024 23:14 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Jun 14, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 14, 2024 23:49 Inactive
@langermank langermank marked this pull request as ready for review June 17, 2024 21:54
@langermank langermank requested review from a team as code owners June 17, 2024 21:54
@langermank langermank requested a review from jonrohan June 17, 2024 21:54
@langermank langermank merged commit 52d8bf7 into main Jun 17, 2024
21 checks passed
@langermank langermank deleted the add-translucent-border branch June 17, 2024 21:54
@primer primer bot mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant