-
Notifications
You must be signed in to change notification settings - Fork 538
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(ToggleSwitch): add support for a ref on the inner <button> eleme…
…nt (#3813) * feat(ToggleSwitch): add support for a `ref` on the inner <button> element * chore: add changeset --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
- Loading branch information
Showing
5 changed files
with
293 additions
and
255 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@primer/react': minor | ||
--- | ||
|
||
Add support for a `ref` on the inner <button> in ToggleSwitch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,184 @@ | ||
import React from 'react' | ||
import {render} from '@testing-library/react' | ||
import ToggleSwitch from './' | ||
import {behavesAsComponent, checkExports, checkStoriesForAxeViolations} from '../utils/testing' | ||
import userEvent from '@testing-library/user-event' | ||
|
||
const SWITCH_LABEL_TEXT = 'Switch label' | ||
|
||
describe('ToggleSwitch', () => { | ||
behavesAsComponent({ | ||
Component: ToggleSwitch, | ||
options: {skipAs: true}, | ||
}) | ||
|
||
checkExports('ToggleSwitch', { | ||
default: ToggleSwitch, | ||
}) | ||
|
||
it('renders a switch that is turned off', () => { | ||
const {getByLabelText} = render( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch aria-labelledby="switchLabel" /> | ||
</>, | ||
) | ||
const toggleSwitch = getByLabelText(SWITCH_LABEL_TEXT) | ||
|
||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'false') | ||
}) | ||
|
||
it('renders a switch that is turned on', () => { | ||
const {getByLabelText} = render( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch aria-labelledby="switchLabel" defaultChecked /> | ||
</>, | ||
) | ||
const toggleSwitch = getByLabelText(SWITCH_LABEL_TEXT) | ||
|
||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'true') | ||
}) | ||
|
||
it('renders a switch that is disabled', async () => { | ||
const user = userEvent.setup() | ||
const {getByLabelText} = render( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch aria-labelledby="switchLabel" disabled /> | ||
</>, | ||
) | ||
const toggleSwitch = getByLabelText(SWITCH_LABEL_TEXT) | ||
|
||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'false') | ||
await user.click(toggleSwitch) | ||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'false') | ||
}) | ||
|
||
it("renders a switch who's state is loading", async () => { | ||
const user = userEvent.setup() | ||
const {getByLabelText, container} = render( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch aria-labelledby="switchLabel" loading /> | ||
</>, | ||
) | ||
const toggleSwitch = getByLabelText(SWITCH_LABEL_TEXT) | ||
const loadingSpinner = container.querySelector('svg') | ||
|
||
expect(loadingSpinner).toBeDefined() | ||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'false') | ||
await user.click(toggleSwitch) | ||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'false') | ||
}) | ||
|
||
it('switches from off to on uncontrolled', async () => { | ||
const user = userEvent.setup() | ||
const {getByLabelText} = render( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch aria-labelledby="switchLabel" /> | ||
</>, | ||
) | ||
const toggleSwitch = getByLabelText(SWITCH_LABEL_TEXT) | ||
|
||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'false') | ||
await user.click(toggleSwitch) | ||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'true') | ||
}) | ||
|
||
it('switches from off to on uncontrolled when clicking on status label', async () => { | ||
const user = userEvent.setup() | ||
const {getByLabelText, getByText} = render( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch aria-labelledby="switchLabel" /> | ||
</>, | ||
) | ||
const toggleSwitch = getByLabelText(SWITCH_LABEL_TEXT) | ||
const toggleSwitchStatusLabel = getByText('Off') | ||
|
||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'false') | ||
await user.click(toggleSwitchStatusLabel) | ||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'true') | ||
}) | ||
|
||
it('switches from off to on with a controlled prop', async () => { | ||
const user = userEvent.setup() | ||
const ControlledSwitchComponent = () => { | ||
const [isOn, setIsOn] = React.useState(false) | ||
|
||
const onClick = () => { | ||
setIsOn(!isOn) | ||
} | ||
|
||
return ( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch onClick={onClick} checked={isOn} aria-labelledby="switchLabel" /> | ||
</> | ||
) | ||
} | ||
const {getByLabelText} = render(<ControlledSwitchComponent />) | ||
const toggleSwitch = getByLabelText(SWITCH_LABEL_TEXT) | ||
|
||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'false') | ||
await user.click(toggleSwitch) | ||
expect(toggleSwitch).toHaveAttribute('aria-pressed', 'true') | ||
}) | ||
|
||
it('calls onChange when the switch is toggled', async () => { | ||
const user = userEvent.setup() | ||
const handleChange = jest.fn() | ||
const ControlledSwitchComponent = ({handleSwitchChange}: {handleSwitchChange: (on: boolean) => void}) => { | ||
const [isOn, setIsOn] = React.useState(false) | ||
|
||
const onClick = () => { | ||
setIsOn(!isOn) | ||
} | ||
|
||
return ( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch onClick={onClick} onChange={handleSwitchChange} checked={isOn} aria-labelledby="switchLabel" /> | ||
</> | ||
) | ||
} | ||
const {getByLabelText} = render(<ControlledSwitchComponent handleSwitchChange={handleChange} />) | ||
const toggleSwitch = getByLabelText(SWITCH_LABEL_TEXT) | ||
|
||
await user.click(toggleSwitch) | ||
expect(handleChange).toHaveBeenCalledWith(true) | ||
}) | ||
|
||
it('can pass data attributes to the rendered component', async () => { | ||
const TEST_ID = 'a test id' | ||
const ControlledSwitchComponent = () => { | ||
return ( | ||
<> | ||
<div id="switchLabel">{SWITCH_LABEL_TEXT}</div> | ||
<ToggleSwitch data-testid={TEST_ID} defaultChecked aria-labelledby="switchLabel" /> | ||
</> | ||
) | ||
} | ||
const {getByTestId} = render(<ControlledSwitchComponent />) | ||
const toggleSwitch = getByTestId(TEST_ID) | ||
expect(toggleSwitch).toBeInTheDocument() | ||
}) | ||
|
||
it('supports a `ref` on the inner <button> element', () => { | ||
const ref = jest.fn() | ||
|
||
render( | ||
<> | ||
<span id="label">label</span> | ||
<ToggleSwitch ref={ref} aria-labelledby="label" /> | ||
</>, | ||
) | ||
|
||
expect(ref).toHaveBeenCalled() | ||
expect(ref).toHaveBeenCalledWith(expect.any(HTMLButtonElement)) | ||
}) | ||
|
||
checkStoriesForAxeViolations('ToggleSwitch.features', '../ToggleSwitch/') | ||
}) |
Oops, something went wrong.