rms unnecessary data-inactive prop

primer · Dec 11, 2023 · 22e5b57 · 22e5b57
1 parent 70f89d8
commit 22e5b57
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/src/ActionList/LinkItem.tsx b/src/ActionList/LinkItem.tsx
@@ -44,7 +44,6 @@ export const LinkItem = React.forwardRef(({sx = {}, active, inactiveText, as: Co
       inactiveText={inactiveText}
       data-inactive={inactiveText ? true : undefined}
       _PrivateItemWrapper={({children, onClick, ...rest}) => {
-        delete rest['data-inactive'] // this attribute gets set on the parent item
         const clickHandler = (event: React.MouseEvent) => {
           onClick && onClick(event)
           props.onClick && props.onClick(event as React.MouseEvent<HTMLAnchorElement>)

diff --git a/src/ActionList/shared.ts b/src/ActionList/shared.ts
@@ -58,7 +58,6 @@ type MenuItemProps = {
   'aria-labelledby'?: string
   'aria-describedby'?: string
   role?: string
-  'data-inactive'?: string
 }
 
 export type ItemContext = Pick<ActionListItemProps, 'variant' | 'disabled'> & {