Skip to content

Commit

Permalink
test(e2e): add e2e test for SelectPanel2 default story (#4279)
Browse files Browse the repository at this point in the history
* fix(SelectPanel2): add aria-labelledby to listbox

* test(e2e): add e2e test for SelectPanel2 default story

* chore: add changeset

* test(vrt): update snapshots

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
  • Loading branch information
joshblack and joshblack authored Feb 20, 2024
1 parent 98e4a61 commit a68e2e2
Show file tree
Hide file tree
Showing 12 changed files with 43 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/fair-trainers-battle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Add aria-labelledby to listbox within draft SelectPanel
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
37 changes: 37 additions & 0 deletions e2e/components/drafts/SelectPanel.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import {test, expect} from '@playwright/test'
import {visit} from '../../test-helpers/storybook'
import {themes} from '../../test-helpers/themes'

test.describe('SelectPanel', () => {
test.describe('Default', () => {
for (const theme of themes) {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'drafts-components-selectpanel--default',
globals: {
colorScheme: theme,
},
})

// Default state
await page.getByText('Assign label').click()
expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(
`drafts.SelectPanel.Default.${theme}.png`,
)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'drafts-components-selectpanel--default',
globals: {
colorScheme: theme,
},
})
await page.getByText('Assign label').click()
await expect(page).toHaveNoViolations()
})
})
}
})
})
1 change: 1 addition & 0 deletions packages/react/src/drafts/SelectPanel2/SelectPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ const Panel: React.FC<SelectPanelProps> = ({
selectionAttribute: 'aria-selected',
selectionVariant: selectionVariant === 'instant' ? 'single' : selectionVariant,
afterSelect: internalAfterSelect,
listLabelledBy: `${panelId}--title`,
}}
>
{childrenInBody}
Expand Down

0 comments on commit a68e2e2

Please sign in to comment.