Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate TextInput to TypeScript #1028

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Migrate TextInput to TypeScript #1028

merged 2 commits into from
Feb 8, 2021

Conversation

colebemis
Copy link
Contributor

This PR migrates the TextInput component to TypeScript as part of the TypeScript refactor.

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 62f45a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 8, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/qui3rfp5f
✅ Preview: https://primer-components-git-cb-ts-text-input.primer.now.sh

@colebemis colebemis mentioned this pull request Feb 8, 2021
Closed
53 tasks
@vercel vercel bot temporarily deployed to Preview February 8, 2021 23:09 Inactive
VanAnderson
VanAnderson approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@VanAnderson VanAnderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as far as I can tell! One small curiousity.

src/TextInput.tsx
Comment on lines 163 to 165

export type TextInputProps = ComponentProps<typeof TextInput>
export default TextInput
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming wrapper props doesn't need it's own export because it's something that's used internally here that would not need to be exposed outside this component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup 👍 No need to expose implementation details

@colebemis colebemis merged commit 88210c2 into main Feb 8, 2021
@colebemis colebemis deleted the cb/ts-text-input branch February 8, 2021 23:27
@github-actions github-actions bot mentioned this pull request Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanAnderson VanAnderson VanAnderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colebemis @VanAnderson