Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OcticonButton
component renders a<button>
with an<Octicon>
in it, and adds the requisite Primer classes to make it not look too button-y. Here's an example of a close button (ref: #114):A couple of other things to note:
text-inherit
class to pass the inheritedcolor
CSS property to the Octicon SVG element.disabled
andonClick
to the<button>
, and support all of our margin and padding whitespace props (m
,p
,mx
,py
, etc.) so that it's easy to space them out and increase their hit area.icon
andsize
props to the Octicon component.label
prop is rendered as thearia-label
attribute.