-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.0.12-beta #143
Merged
Merged
Release v0.0.12-beta #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
force-pushed
the
release-0.0.12-beta
branch
from
July 26, 2018 21:09
6d776e4
to
97c09c7
Compare
This was referenced Jul 26, 2018
Merged
Add displayName to all components with babel plugin
Revert "Add displayName to all components with babel plugin"
3 tasks
Sorry for making such a mess of this PR, folks! I think it's in good shape now. |
emplums
suggested changes
Jul 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run a build on this docs before you deploy? Otherwise this looks good!
emplums
approved these changes
Jul 27, 2018
Rework UnderlineNav active class logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must
Should
displayName
on every component for a friendlier debugging experience Add displayName to all components with babel plugin #142Could
master
Warn us when the PR base branch is master #140