Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: allow "falsely" input values #2127

Closed
wants to merge 12 commits into from
Closed

Autocomplete: allow "falsely" input values #2127

wants to merge 12 commits into from

Conversation

Swiftwork
Copy link
Contributor

@Swiftwork Swiftwork commented Jun 17, 2022

Changed the autocomplete input value prop to allow both the number 0 and undefined so that the text input can be cleared programmatically.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Closes #1995

@Swiftwork Swiftwork requested review from a team and mperrotti June 17, 2022 18:04
@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2022

🦋 Changeset detected

Latest commit: 5f0bbaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Swiftwork Swiftwork marked this pull request as draft June 17, 2022 18:06
@Swiftwork Swiftwork marked this pull request as ready for review June 17, 2022 18:14
@mperrotti
Copy link
Contributor

@Swiftwork - Since you're an external contributory, I cherry-picked your commits and opened a PR directly off this repo #2154

Thank you!

@mperrotti mperrotti closed this Jun 28, 2022
@Swiftwork
Copy link
Contributor Author

See the reply here #2116 (comment) regarding future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete.Input does not allow value to be set to empty string ""
5 participants