Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Position component examples #215

Merged
merged 3 commits into from
Aug 16, 2018
Merged

Conversation

shawnbot
Copy link
Contributor

This adds examples for the positioning components. Some sizing tricks were necessary to get the sticky demo working, but I think it does the job.

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

<Fixed bottom={0} right={0} bg="red.2" p={2}>
I'm fixed to the bottom right.
</Fixed>
`.trim()}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta remember this .trim() trick for the examples 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, what'd be even better is using something like dedent so that we can indent the first line "properly".

@shawnbot shawnbot merged commit ea81037 into release-2.0.0-beta Aug 16, 2018
@shawnbot shawnbot deleted the position-examples branch August 16, 2018 19:43
@shawnbot shawnbot mentioned this pull request Aug 16, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants