-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back Primer CSS build and instructions for using it #260
Conversation
This pull request is automatically deployed with Now. |
This comment has been minimized.
This comment has been minimized.
Looks like the npm registry is flaking out on those last couple of Now deployments. Let's take another look at this on Monday. 🤞 |
Well, using preval might not work here after all... this is super frustrating. I can't even reproduce the errors that are happening on Now locally. |
This comment has been minimized.
This comment has been minimized.
@shawnbot is this ready to re-review? |
@emplums yep! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
Fixes #124. I went back and forth on whether to include an actual React component for including the CSS, and after thrashing on bundling the CSS at build time a bit I settled on simply building
dist/primer-components.css
and documenting a couple of ways to import that file into various flavors of app.The rendered README section has usage instructions; let me know if they don't make sense!
While I was in there, I revived server-side rendering of the
styled-components
CSS, so all of the styles should be available before any content is loaded on the site unless they're rendered only client-side.I've also updated
styled-system
andsystem-components
to their latest respective versions now thatstyled-system@3.1.3
fixed the missingspace
export. 😱