Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underlinenav2: Add a z-index on the disclosure menu #3200

Merged
merged 3 commits into from
May 2, 2023
Merged

Underlinenav2: Add a z-index on the disclosure menu #3200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ad39a7
Underlinenav2: Add a z-index on the disclosure menu
broccolinisoup Apr 20, 2023
25ecd9b
add changeset
broccolinisoup Apr 20, 2023
d635c9a
Merge branch 'main' into bs/underline-stacking-fix
broccolinisoup Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-papayas-brush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

UnderlineNav2: Add a z-index to make it appear on the top of the stack
1 change: 1 addition & 0 deletions src/UnderlineNav2/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ export const menuItemStyles = {

export const menuStyles = {
position: 'absolute',
zIndex: 1,
top: '90%',
right: '0',
boxShadow: '0 1px 3px rgba(0, 0, 0, 0.12), 0 1px 2px rgba(0, 0, 0, 0.24)',
Expand Down