Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DataTable): add Table.ErrorDialog component #3276

Merged
merged 7 commits into from
May 19, 2023

Conversation

joshblack
Copy link
Member

This PR adds in an ErrorDialog component to mirror TreeView.ErrorDialog but for the DataTable set of components.

Changelog

New

  • Add Table.ErrorDialog component
  • Add "With Network Error" story

Changed

Removed

@joshblack joshblack requested review from colebemis and a team May 11, 2023 17:04
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: 241fcc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack changed the title feat(DataTable): add ErrorDialog component feat(DataTable): add Table.ErrorDialog component May 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 115.97 KB (0%)
dist/browser.umd.js 117.81 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-3276 May 11, 2023 17:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3276 May 11, 2023 17:12 Inactive
@primer primer bot temporarily deployed to github-pages May 11, 2023 17:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3276 May 11, 2023 17:14 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

const id = url.toString()
if (!cache.has(id)) {
cache.set(id, Repo.pageInfo(pageSize))
export function useFlakeyQuery<T>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha love it ❤️

@joshblack joshblack enabled auto-merge May 15, 2023 19:28
@joshblack joshblack temporarily deployed to github-pages May 15, 2023 19:35 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3276 May 15, 2023 19:35 Inactive
@joshblack joshblack added this pull request to the merge queue May 19, 2023
Merged via the queue into main with commit 8abf268 May 19, 2023
@joshblack joshblack deleted the feat/add-error-dialog-component branch May 19, 2023 15:00
This was referenced May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants