Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update accessibility-alt-text-bot.yml #3326

Merged
merged 4 commits into from
May 25, 2023
Merged

Update accessibility-alt-text-bot.yml #3326

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d281f4
Update accessibility-alt-text-bot.yml
kendallgassner May 25, 2023
b118439
format
kendallgassner May 25, 2023
17f8582
add contents
kendallgassner May 25, 2023
378bec3
add contents
kendallgassner May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/accessibility-alt-text-bot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,18 @@ on:
types: [opened, edited]
issue_comment:
types: [created, edited]
discussion:
types: [created, edited]

permissions:
issues: write
pull-requests: write
Comment on lines +13 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if this will cover discussions.

I didn't see anything else in the permissions list that seemed discussion-y... maybe contents: write?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I couldn't figure out which permission was right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am down to try content!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was looking at: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#overview real quick, would these permissions work or would that run into the same situation as before?

permissions:
  issues: write
  discussions: write
  pull-requests: write

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I must've been looking at outdated docs! discussions seems the way to go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated! thank you for the find


jobs:
accessibility_alt_text_bot:
name: Check alt text is set on issue or pull requests
runs-on: ubuntu-latest
if: ${{ github.event.issue || github.event.pull_request }}
if: ${{ github.event.issue || github.event.pull_request || github.event.discussion }}
steps:
- name: Get action 'github/accessibility-alt-text-bot'
uses: github/accessibility-alt-text-bot@v1.0.0
uses: github/accessibility-alt-text-bot@v1.1.0