Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnderlineNav2: Correct the icon colours to be fg.muted #3446

Merged
merged 3 commits into from
Jun 28, 2023
Merged

UnderlineNav2: Correct the icon colours to be fg.muted #3446

merged 3 commits into from
Jun 28, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Jun 23, 2023 •
edited
Loading

The icons on UnderlineNav should be muted to match the current implementation and the rest of the website. reference (GitHub stuff only)

Screenshots

Before

Light
An example with 5 nav items of the GitHub main navigation on a light mode with icons have muted black color
Dark Dimmed
An example with 5 nav items of the GitHub main navigation on a dark dimmed mode with icons have brighter and high contrast gray color

After

Light
An example with 5 nav items of the GitHub main navigation on a light mode with icons have high contrast black color
Dark Dimmed
An example with 5 nav items of the GitHub main navigation on a dark dimmed mode with icons have muted gray color

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup requested review from a team and joshblack June 23, 2023 02:07
@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 31d3e0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 101.95 KB (+0.02% 🔺)
dist/browser.umd.js 102.5 KB (+0.01% 🔺)

@broccolinisoup broccolinisoup temporarily deployed to github-pages June 23, 2023 02:12 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3446 June 23, 2023 02:12 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages June 23, 2023 02:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3446 June 23, 2023 02:22 Inactive
@broccolinisoup broccolinisoup added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit 650a46d Jun 28, 2023
@broccolinisoup broccolinisoup deleted the bs/underlinenav-icon-fg-muted branch June 28, 2023 23:34
@primer-css primer-css mentioned this pull request Jun 28, 2023
Merged
@skemex skemex mentioned this pull request May 24, 2024
Open
@rbragaru rbragaru mentioned this pull request Aug 14, 2024
Open
@skemex skemex mentioned this pull request Sep 24, 2024
Open
@skemex skemex mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@maximedegreve maximedegreve maximedegreve approved these changes

@joshblack joshblack Awaiting requested review from joshblack

@mperrotti mperrotti Awaiting requested review from mperrotti

Assignees

@broccolinisoup broccolinisoup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@broccolinisoup @maximedegreve @langermank