Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): bump @lit-labs/react from 1.1.1 to 2.0.1 (#3652)" #3708

Merged

Conversation

joshblack
Copy link
Member

This reverts commit 440829c.

This change unfortunately impacts anyone who uses the lib entrypoint as we compile the @lit-labs/react package into a CommonJS format which collapses the exports field in that package's package.json file.

This file is important because it specifies which entrypoints to use for the browser versus node. When that information is lost, it will attempt to run the code intended for the browser in a Node.js environment which causes errors like useLayoutEffect.

I'm unsure how to best address this so wanted to roll back and then come back with a plan for this work.

@joshblack joshblack requested review from a team and josepmartins September 5, 2023 16:58
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

⚠️ No Changeset found

Latest commit: d15b881

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.65 KB (+0.07% 🔺)
dist/browser.umd.js 105.22 KB (+0.08% 🔺)

@mperrotti
Copy link
Contributor

mperrotti commented Sep 5, 2023

I'm unsure how to best address this so wanted to roll back and then come back with a plan for this work.

Do we have an issue for this work yet? If not, we may want to create one so this work gets prioritized and doesn't "slip through the cracks".

@joshblack
Copy link
Member Author

@mperrotti opened one over here: #3710

@joshblack joshblack added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit ee511fd Sep 5, 2023
33 of 34 checks passed
@joshblack joshblack deleted the revert-3652-dependabot/npm_and_yarn/lit-labs/react-2.0.1 branch September 5, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants