SelectPanel2: Remove instant sorting in stories #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
siddharthkp
requested review from
broccolinisoup
and removed request for
joshblack
siddharthkp
changed the title
siddharthkp
commented
Sep 21, 2023
| @@ -58,6 +58,7 @@ const SelectPanel = props => { | |||
| } | |||
| // @ts-ignore todo | |||
| const onInternalSubmit = event => { | |||
| event.preventDefault() | |||
There was a problem hiding this comment.
(intentional change) Bonus nice to have!
size-limit report 📦
|
broccolinisoup
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items should not move when selecting elements. From Chelsea:
Note: This PR removes the divider and does not implement the second part of #2644 (when the input filter is emptied, selected items should be moved to the top). Keeping #2644 open until I add that.
sorting-before.mov
sorting-after.mov