Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selectpanel2: Remove SelectPanel.ActionList API #3764

Merged
merged 43 commits into from
Oct 2, 2023
Merged

Selectpanel2: Remove SelectPanel.ActionList API #3764

merged 43 commits into from
Oct 2, 2023

Commits on Sep 20, 2023

  1. remove sort + divider

    @siddharthkp
    siddharthkp committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    080351c View commit details
    Browse the repository at this point in the history

  2. reorder state to be more cohesive

    @siddharthkp
    siddharthkp committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    445e150 View commit details
    Browse the repository at this point in the history

  3. clean up suspended story

    @siddharthkp
    siddharthkp committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3b36ae0 View commit details
    Browse the repository at this point in the history

  4. clean up C and D

    @siddharthkp
    siddharthkp committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f14d727 View commit details
    Browse the repository at this point in the history

  5. A: sort items to show initially selected ones first

    @siddharthkp
    siddharthkp committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c7ed2d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. add event.preventDefault by default

    @siddharthkp
    siddharthkp committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    6296f32 View commit details
    Browse the repository at this point in the history

  2. add initial sorting function to stories

    @siddharthkp
    siddharthkp committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    7350510 View commit details
    Browse the repository at this point in the history

  3. add missing props for D with use transition

    @siddharthkp
    siddharthkp committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a5dbe92 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Replace SelectPanel.Heading with title

    @siddharthkp
    siddharthkp committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    2f12c35 View commit details
    Browse the repository at this point in the history

  2. add default footer

    @siddharthkp
    siddharthkp committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    8413f74 View commit details
    Browse the repository at this point in the history

  3. add minimal story

    @siddharthkp
    siddharthkp committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a7208c3 View commit details
    Browse the repository at this point in the history

  4. oops, it's not possible to have query

    @siddharthkp
    siddharthkp committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    39f6779 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into drafts-replace-heading-with-title

    @siddharthkp
    siddharthkp authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    7689c7f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. clean up story with tabs

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7ce02ba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'drafts-replace-heading-with-title' of github.com:primer… 

    …/react into drafts-replace-heading-with-title
    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    796effe View commit details
    Browse the repository at this point in the history

  3. Add option for external anchor

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    88f27e5 View commit details
    Browse the repository at this point in the history

  4. improve custom events story

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    6fc2508 View commit details
    Browse the repository at this point in the history

  5. story: bring back filter for Filter story

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    dd17537 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'drafts-replace-heading-with-title' into drafts-external… 

    …-anchor
    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d774dd8 View commit details
    Browse the repository at this point in the history

  7. rename story

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    5dd2853 View commit details
    Browse the repository at this point in the history

  8. remove the need for SelectPanel.ActionList

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    211d5ba View commit details
    Browse the repository at this point in the history

  9. add selection variable by default

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4720653 View commit details
    Browse the repository at this point in the history

  10. add list and item role automatically

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ba07364 View commit details
    Browse the repository at this point in the history

  11. oops, unused imports

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a4197ad View commit details
    Browse the repository at this point in the history

  12. reduce scope

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1420edc View commit details
    Browse the repository at this point in the history

  13. update ActionList snapshot

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    be44380 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into drafts-selectpanel-simplify-actionlist

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d34ca0a View commit details
    Browse the repository at this point in the history

  15. fix bad merge, sorry!

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0d08c01 View commit details
    Browse the repository at this point in the history

  16. missed a spot!

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a7fa2d9 View commit details
    Browse the repository at this point in the history

  17. remove unrelated change

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9bf52b9 View commit details
    Browse the repository at this point in the history

  18. update snapshots

    @siddharthkp
    siddharthkp committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    6753461 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. bring back explicit footer for suspense

    @siddharthkp
    siddharthkp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    6011cc6 View commit details
    Browse the repository at this point in the history

  2. Add warning to ActionMenu story

    @siddharthkp
    siddharthkp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    40d3c57 View commit details
    Browse the repository at this point in the history

  3. undefined can't be a string!

    @siddharthkp
    siddharthkp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8e00e7f View commit details
    Browse the repository at this point in the history

  4. test(vrt): update snapshots

    @siddharthkp @github-actions
    siddharthkp authored and github-actions[bot] committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    02901a8 View commit details
    Browse the repository at this point in the history

  5. found an easier way to style

    @siddharthkp
    siddharthkp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    279e846 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge branch 'main' into drafts-selectpanel-simplify-actionlist

    @siddharthkp
    siddharthkp authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    eed8da1 View commit details
    Browse the repository at this point in the history

  2. Revert "test(vrt): update snapshots" 

    This reverts commit 02901a8.
    @siddharthkp
    siddharthkp committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f046646 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'drafts-selectpanel-footer-fix' into drafts-selectpanel-… 

    …simplify-actionlist
    @siddharthkp
    siddharthkp committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    9f8cf08 View commit details
    Browse the repository at this point in the history

  4. Empty message should be out of ActionList

    @siddharthkp
    siddharthkp committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    d1c872b View commit details
    Browse the repository at this point in the history

  5. footer outside BOx

    @siddharthkp
    siddharthkp committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    283f800 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into drafts-selectpanel-simplify-actionlist

    @siddharthkp
    siddharthkp authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    332e132 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Merge branch 'main' into drafts-selectpanel-simplify-actionlist

    @siddharthkp
    siddharthkp authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    7e8b46a View commit details
    Browse the repository at this point in the history