Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade popover-polyfill to latest #3896

Merged
merged 1 commit into from
Nov 1, 2023
Merged

upgrade popover-polyfill to latest #3896

merged 1 commit into from
Nov 1, 2023

Conversation

keithamus
Copy link
Member

Changelog

New

Changed

Upgrade @oddbird/popover-polyfill to 0.3.2.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@keithamus keithamus added the skip changeset This change does not need a changelog label Nov 1, 2023
@keithamus keithamus requested review from a team and siddharthkp November 1, 2023 11:30
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: cb1c0f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@keithamus keithamus force-pushed the upgrade-popover-polyfill-to-latest branch from 39ece1c to 4335e51 Compare November 1, 2023 11:31
@keithamus keithamus force-pushed the upgrade-popover-polyfill-to-latest branch from 4335e51 to cb1c0f3 Compare November 1, 2023 11:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.05 KB (+0.49% 🔺)
dist/browser.umd.js 104.61 KB (+0.47% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3896 November 1, 2023 11:38 Inactive
siddharthkp
siddharthkp approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@keithamus keithamus added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 95dc202 Nov 1, 2023
29 checks passed
@keithamus keithamus deleted the upgrade-popover-polyfill-to-latest branch November 1, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithamus @siddharthkp