Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dialog v1 unit tests to __tests__ folder and update v1 stories #4055

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Dec 13, 2023

Closes #

Realised that the unit tests in the Dialog.test.tsx is for Dialog v1 but the file is located in the src/Dialog folder which makes it confusing and makes people think they are for v2?

Also src/Dialog.stories.tsx and src/Dialog/Dialog.stories.tsx both use the same Dialog v2. I don't think this was intentional.

Changelog

New

Changed

Moved Dialog.tests.tsx from src/Dialog/ to src/__tests__ folder because it is written for v1.
Update src/Dialog.stories.tsx to use Dialog v1 instead of Dialog v2.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Only affects the test files. No impact on the import path or public api.

Testing & Reviewing

CI test job should be green and if you would like to be double sure, you can update the import in the test file to be import {Dialog} from '../Dialog/Dialog' and confirm that there are errors on the page because it is different than the expected Dialog.

Merge checklist

Copy link

changeset-bot bot commented Dec 13, 2023

⚠️ No Changeset found

Latest commit: 34552f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Dec 13, 2023
@broccolinisoup broccolinisoup changed the title Dialog unit tests are written for v1 but in the v2 folder Move Dialog v1 unit tests to __tests__ folder from Dialog v2 folder Dec 13, 2023
Copy link
Contributor

github-actions bot commented Dec 13, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 105.54 KB (0%)
dist/browser.umd.js 106.13 KB (0%)

@broccolinisoup broccolinisoup marked this pull request as ready for review December 13, 2023 01:46
@broccolinisoup broccolinisoup requested review from a team and siddharthkp December 13, 2023 01:46
@github-actions github-actions bot temporarily deployed to storybook-preview-4055 December 13, 2023 01:50 Inactive
@broccolinisoup broccolinisoup changed the title Move Dialog v1 unit tests to __tests__ folder from Dialog v2 folder Move Dialog v1 unit tests to __tests__ folder and update v1 stories Dec 13, 2023
@broccolinisoup broccolinisoup added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 71baff3 Dec 14, 2023
30 checks passed
@broccolinisoup broccolinisoup deleted the dialog-tests-are-for-v1 branch December 14, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants