-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Dialog v1 unit tests to __tests__
folder and update v1 stories
#4055
Conversation
|
__tests__
folder from Dialog v2 folder
size-limit report 📦
|
__tests__
folder from Dialog v2 folder__tests__
folder and update v1 stories
Closes #
Realised that the unit tests in the
Dialog.test.tsx
is for Dialog v1 but the file is located in thesrc/Dialog
folder which makes it confusing and makes people think they are for v2?Also
src/Dialog.stories.tsx
and src/Dialog/Dialog.stories.tsx
both use the same Dialog v2. I don't think this was intentional.Changelog
New
Changed
Moved Dialog.tests.tsx from
src/Dialog/
tosrc/__tests__
folder because it is written for v1.Update
src/Dialog.stories.tsx
to use Dialog v1 instead of Dialog v2.Removed
Rollout strategy
Only affects the test files. No impact on the import path or public api.
Testing & Reviewing
CI test job should be green and if you would like to be double sure, you can update the import in the test file to be
import {Dialog} from '../Dialog/Dialog'
and confirm that there are errors on the page because it is different than the expected Dialog.Merge checklist