-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Tooltip border-radius from 3px to 6px #4204
Conversation
🦋 Changeset detectedLatest commit: a4edb42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will defer to @langermank for a visual review 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up we're about to refactor this design (CC @broccolinisoup) but probably no harm in merging this?
Thanks for the heads up @langermank !! No problem at all, I'll just take that line back in this PR |
@langermank @broccolinisoup Can either of you help me with the failing test on this? I’m not sure where/how to update it. |
@dylanatsmith try running |
Thanks @joshblack @langermank 🙏 |
The Tooltip border-radius is inconsistent between Rails and React components. This is obvious where the two live side-by-side, like the global Copilot header button.
This PR assumes Rails is correct and changes React to match.
Screen.Recording.2024-02-01.at.11.59.58.mov
Screen.Recording.2024-02-01.at.12.00.24.mov
Changelog
New
Changed
Tooltip border-radius
Rollout strategy
Testing & Reviewing
Merge checklist