refactor(tsconfig): enable verbatimModuleSyntax

[joshblack]

Based on changes over in: https://github.com/github/github/pull/293430

This PR enables the verbatimModuleSyntax option in our base tsconfig. This change prevents some of the challenges we were running into where Gatsby or Storybook were reporting issues importing/finding certain imports that were using type elision (where TS detects that you're importing a type but bundlers may not be aware that it is a type).

Note: this still allows mixed imports as long as type is included before the named import. For example:

import { ExampleExport, type ExampleExportProps } from './example';

Changelog

New

Changed

• Enable verbatimModuleSyntax option in tsconfig.base.json
• Enable eslint rule for this syntax
• Run autofix for eslint rule to refactor imports

Removed

Rollout strategy

• None; if selected, include a brief description as to why

I believe no public change should be perceivable through this refactor

Testing & Reviewing

• Would love to hear what folks think of enabling this rule and its impact on PRC
• Are there any downsides to enabling this rule?

[changeset-bot]

⚠️ No Changeset found

Latest commit: b2802d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	113.37 KB (0%)
packages/react/dist/browser.umd.js	114.03 KB (0%)

[siddharthkp]

TIL!

I don't know the tradeoffs of this, but trust you with it!

Just confirming, I understand this does not change how types can imported outside the package, right?

[joshblack]

@siddharthkp correct! Should be no change at all downstream. I think that, for us, the only drawback is that we have to explicitly annotate type imports.