Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placeholder selector for form components #4295

Merged
merged 6 commits into from
Feb 26, 2024
Merged

Conversation

langermank
Copy link
Contributor

Placeholder text came up during the v8 color staff ship. It looks like the selector wasn't properly selecting, which could lead to unexpected results.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@langermank langermank requested review from a team and joshblack February 21, 2024 20:32
Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 853bda0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 21, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.48 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 114.16 KB (+0.02% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4295 February 21, 2024 22:33 Inactive
@langermank langermank added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2024
@langermank langermank added this pull request to the merge queue Feb 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 22, 2024
Merged via the queue into main with commit e1dbd6a Feb 26, 2024
36 checks passed
@langermank langermank deleted the fix-placeholder-color branch February 26, 2024 20:04
@primer primer bot mentioned this pull request Feb 26, 2024
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
* fix selector

* Create young-bikes-kneel.md

* snaps

* test(vrt): update snapshots

* Update young-bikes-kneel.md

---------

Co-authored-by: langermank <langermank@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants