-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BranchName: Add style for span and add v8 tokens #4556
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a7d44d1
add style for branchName as span adn add v8 tokens
lukasoppermann 717c84b
added changeset
lukasoppermann 0c1d39e
Update thin-ligers-turn.md
siddharthkp e47fe1a
test(vrt): update snapshots
lukasoppermann 4b103cc
use not a instead of matching for span
lukasoppermann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@primer/react': patch | ||
--- | ||
|
||
BranchName: Fixing text color when rendered as span |
Binary file modified
BIN
+1.91 KB
(130%)
...BranchName.test.ts-snapshots/BranchName-Default-dark-colorblind-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.93 KB
(130%)
...nents/BranchName.test.ts-snapshots/BranchName-Default-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.84 KB
(130%)
...nts/BranchName.test.ts-snapshots/BranchName-Default-dark-dimmed-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.83 KB
(130%)
...omponents/BranchName.test.ts-snapshots/BranchName-Default-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.91 KB
(130%)
...components/BranchName.test.ts-snapshots/BranchName-Default-dark-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.98 KB
(130%)
...nchName.test.ts-snapshots/BranchName-Default-dark-high-contrast-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2 KB
(130%)
...ts/BranchName.test.ts-snapshots/BranchName-Default-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.93 KB
(130%)
...shots/components/BranchName.test.ts-snapshots/BranchName-Default-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.91 KB
(130%)
...BranchName.test.ts-snapshots/BranchName-Default-dark-tritanopia-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.93 KB
(130%)
...nents/BranchName.test.ts-snapshots/BranchName-Default-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.99 KB
(130%)
...ranchName.test.ts-snapshots/BranchName-Default-light-colorblind-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.92 KB
(130%)
...ents/BranchName.test.ts-snapshots/BranchName-Default-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.99 KB
(130%)
...omponents/BranchName.test.ts-snapshots/BranchName-Default-light-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.04 KB
(130%)
...chName.test.ts-snapshots/BranchName-Default-light-high-contrast-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.98 KB
(130%)
...s/BranchName.test.ts-snapshots/BranchName-Default-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.92 KB
(130%)
...hots/components/BranchName.test.ts-snapshots/BranchName-Default-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.99 KB
(130%)
...ranchName.test.ts-snapshots/BranchName-Default-light-tritanopia-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.92 KB
(130%)
...ents/BranchName.test.ts-snapshots/BranchName-Default-light-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,16 @@ | ||
import React from 'react' | ||
import type {Meta} from '@storybook/react' | ||
import BranchName from './BranchName' | ||
import {Stack} from '../Stack' | ||
|
||
export default { | ||
title: 'Components/BranchName', | ||
component: BranchName, | ||
} as Meta<typeof BranchName> | ||
|
||
export const Default = () => <BranchName href="#">branch_name</BranchName> | ||
export const Default = () => ( | ||
<Stack align="start"> | ||
<BranchName href="#">branch_name</BranchName> | ||
<BranchName as="span">branch_name as span</BranchName> | ||
</Stack> | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!